[flow-strict] Flow strict in DatePickerAndroid.android.js, DatePickerAndroid.ios.js

[nissy-dev]

Related to #22100

Turn Flow strict mode on for DatePickerAndroid

Test Plan:

• npm run prettier
• npm run flow-check-ios
• npm run flow-check-android

This error was happend #22101 #22048

Release Notes:

[GENERAL] [ENHANCEMENT] [Components/DatePickerAndroid/DatePickerAndroid.android.js] - Flow strict mode
[GENERAL] [ENHANCEMENT] [Components/DatePickerAndroid/DatePickerAndroid.ios.js] - Flow strict mode

[nissy-dev]

I got this error...

// Getters and setters can have side effects and are unsafe. (unsafe-getters-setters)
static get dismissedAction() {
    return 'dismissedAction';
}

I should add unsafe.enable_getters_and_setters in .flowconfig?

[empyrical]

I am not quite sure why those are getters. (Perhaps in an earlier revision, they were getting things from NativeModules?)

But you should be able to change them to normal static properties like:

static dismissedAction = 'dismissedAction';

[nissy-dev]

@empyrical
Thank you for advice! I fixed.

[facebook-github-bot]

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[elicwhite]

We have two internal flow errors from this change:

Cannot call await with `DatePickerAndroid.open(...)` bound to `p` because property `action` is missing in `Promise` [1].
                                                   v-----------------------
  87|     const {action, year, month, day} = await DatePickerAndroid.open({
  88|       date: this._getDefaultStartDate(),
  89|       minDate: minDate,
  90|       maxDate: maximumDate,
  91|     });
      -----^
References:
  react-native/Libraries/Components/DatePickerAndroid/DatePickerAndroid.ios.js:35:33
  35|   async open(options: Options): Promise<DatePickerModuleOpen> {
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [1]

It looks like it expects action as part of the resolved promise. Is that something native actually provides and the type should be including or does it seem like a bug in our callsites?

[nissy-dev]

I refer to these lines. I seem that the native provides action(always), year, month day.

react-native/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogModule.java

Lines 116 to 120 in 0a39cda

	* @param promise This will be invoked with parameters action, year,
	* month (0-11), day, where action is {@code dateSetAction} or
	* {@code dismissedAction}, depending on what the user did. If the action is
	* dismiss, year, month and date are undefined.
	*/

But, the error which you got happened in DatePickerAndroid.ios.js
In the case of ios, DatePickerAndroid.open() always return Promise.reject().
So, I fix in DatePickerAndroid.ios.js. Is it OK...?

[facebook-github-bot]

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[elicwhite]

@nd-02110114, was there a reason that you closed this PR? We hadn't gotten a chance to finish landing it but it was on our radar. I'd still like to land it. :-/

[nissy-dev]

@TheSavior
I'm so sorry 🙇 Reopened!!

[react-native-bot]

@nd-02110114 merged commit 60f3b53 into facebook:master.