Fixed crash when moduleCalss init calls enqueueJSCall #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ridge setup is complete
facebook-github-bot
added
the
CLA Signed
|
@tadeuzagallo is this fix included in your bridge changes already, or is it a new issue? |
|
It's included, we talked about it on the issue instead of in the PR, but I believe it can be closed. |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
Remove `openSettings` from docs for v0.59
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
May 13, 2022
…p-14 chore: Use node 14 for Apple test loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1116 (it contains more detailed explanation)
In short
RCTBridge.setUpcalls[[moduleClass alloc] init]which can callbridge.enqueueJSCalland create a crash because bridge.setUp not yet finished