Race condition in RCTBridge

[artemyarulin]

1. RCTBridge.setUp is executing. On some moment module is created using [[moduleClass alloc] init]
2. RCTReachability.m subscribes to event in init method: SCNetworkReachabilitySetCallback(_reachability, RCTReachabilityCallback, &context);
3. RCTBridge.setUp continuing and calls RCTLocalModulesConfig
4. RCTReachabilityCallback is called and executes eventDispathed.sendDeviceEventWithName -> enqueueJSCall
5. enqueueJSCall - crashes because there are no modules exists yet

[artemyarulin]

Here pull request which fixes this issue (actually I guess this is a real reason for #1114).

Now I'm thinking that it worth giving user a warning that his call is ignored because RCTBridge still initializing, what do you think?

[nicklockwood]

Cc: @tadeuzagallo, who's been working on a unified solution for these race conditions.

[tadeuzagallo]

Thanks @artemyarulin for raising that issue!

I had moved the _loading already, but after your comment I figured out a way so we never ignore any call, so it should be alright now.

The commit hasn't landed internally yet, but I'm working on it, shouldn't take long now.

[artemyarulin]

@tadeuzagallo Cool, thank you!

[nicklockwood]

Fixed in #1165