Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use new Argos playwright integration #9419

Merged
merged 5 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/argos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ jobs:
steps:
- name: Check out repository code
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
with:
# A minimal fetch-depth of 2 is required
# to automatically detect branch in @argos-ci/cli
fetch-depth: 2

- name: Use Node.js
uses: actions/setup-node@v3
Expand All @@ -49,7 +45,3 @@ jobs:

- name: Take Argos screenshots
run: yarn argos:screenshot

- name: Upload Argos screenshots
continue-on-error: true
run: yarn argos:upload
3 changes: 1 addition & 2 deletions argos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"report": "playwright show-report"
},
"dependencies": {
"@argos-ci/cli": "^0.4.6",
"@argos-ci/playwright": "^0.0.6",
"@argos-ci/playwright": "1.0.0-alpha.4",
"@playwright/test": "^1.36.1",
"cheerio": "^1.0.0-rc.12"
}
Expand Down
2 changes: 2 additions & 0 deletions argos/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import type {PlaywrightTestConfig} from '@playwright/test';
const config: PlaywrightTestConfig = {
testDir: './tests',

reporter: [['list'], ['@argos-ci/playwright/reporter']],

// Run website production built
// Need to run "yarn website:build:fast" before
webServer: {
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"crowdin:download": "crowdin download --config ./crowdin-v2.yaml",
"crowdin:download:website": "yarn crowdin:download --language fr --language ko --language pt-BR --language zh-CN --language ja",
"argos:screenshot": "yarn workspace argos screenshot",
"argos:upload": "yarn workspace argos upload",
"canary": "yarn canary:bumpVersion && yarn canary:publish",
"canary:version": "echo 0.0.0-`git rev-list --count HEAD`+`git rev-parse --short HEAD`",
"canary:bumpVersion": "yarn lerna version `yarn --silent canary:version` --exact --no-push --yes",
Expand Down
Loading
Loading