Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use new Argos playwright integration #9419

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

gregberge
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Upgrade Argos experience.

Test Plan

Check Argos build.

@netlify
Copy link

netlify bot commented Oct 20, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit a3d7266
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65328994785a7f0008d861db
😎 Deploy Preview https://deploy-preview-9419--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 74 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation/ 🟠 79 🟢 98 🟢 92 🟢 100 🟠 89 Report
/docs/category/getting-started/ 🟢 94 🟢 100 🟢 92 🟢 90 🟠 89 Report
/blog/ 🟠 77 🟢 100 🟢 92 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3/ 🟠 75 🟢 97 🟢 92 🟢 100 🟠 89 Report
/blog/tags/release/ 🟠 82 🟢 100 🟢 92 🟠 80 🟠 89 Report
/blog/tags/ 🟠 87 🟢 100 🟢 92 🟢 90 🟠 89 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 20, 2023
@slorber slorber added pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. Argos Add this label to run UI visual regression tests. See argos.yml GH action. labels Oct 20, 2023
@argos-ci
Copy link

argos-ci bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 1 change Oct 20, 2023, 2:56 PM

@slorber
Copy link
Collaborator

slorber commented Oct 20, 2023

hmmm, not sure what is happening @gregberge but CI is failing:

CleanShot 2023-10-20 at 13 11 37@2x

https://github.com/facebook/docusaurus/actions/runs/6586648406/job/17895365157?pr=9419

Kind of mysterious your bot posted a comment here 😅

CleanShot 2023-10-20 at 13 13 11@2x

@gregberge
Copy link
Contributor Author

@slorber I am fixing it, thanks! That's because you use an outdated version of Playwright but it should work anyway.

@slorber
Copy link
Collaborator

slorber commented Oct 20, 2023

@slorber I am fixing it, thanks! That's because you use an outdated version of Playwright but it should work anyway.

thanks

Still failing apparently

CleanShot 2023-10-20 at 15 30 41@2x

@gregberge
Copy link
Contributor Author

@slorber should be OK now, tested it locally.

@slorber slorber merged commit 2bb4fd0 into facebook:main Oct 20, 2023
24 of 26 checks passed
slorber added a commit that referenced this pull request Oct 24, 2023
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants