Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit date selection field for non time based searches #160

Closed

Conversation

quintanilhar
Copy link
Contributor

Hello guys!

It will omit the date select field for non-time based searches.

The HTTP Search (non-time based) will look like this:
image

The ECL Search will look like as before:
image

This PR's closes #114.

@kiwiz
Copy link
Contributor

kiwiz commented Oct 30, 2017

Thanks for the PR! Some additional work needs to be done for Searches that support multiple sources. The Elasticsearch_Search is a good example: It has a isTimeBased method that gives this information.

I think we'll need the following:

  • Pass a mapping of [sources -> whether it's time based] to the front end via REST_Data.
  • Look up the key whenever the source type changes and show/hide the buttons.

Lemme know if you'd like to take a stab at this. I'm also happy to merge this and finish up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable date-selection for Search types that don't have a concept of time
2 participants