Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable date-selection for Search types that don't have a concept of time #114

Open
kiwiz opened this issue Apr 4, 2017 · 5 comments
Open

Comments

@kiwiz
Copy link
Contributor

kiwiz commented Apr 4, 2017

The Search management UI allows you to both test and execute searches against a specific point in time. This is useful for search types like Elasticsearch (via @timestamp) but is meaningless for searches that have no concept of time (like HTTP). In the latter case, we should just hide the time selection functionality (The wrench icon).

The isTimeBased method on Searches will tell you whether these elements should be visible, but it varies depending on which source (in the case of Elasticsearch, which cluster) you're targeting. We'd need a bit of js to check the current source cluster and hide/show the buttons accordingly.

@kiwiz kiwiz self-assigned this Apr 18, 2017
@quintanilhar
Copy link
Contributor

Could you @kiwiz give more details about this issue?

@kiwiz
Copy link
Contributor Author

kiwiz commented Oct 18, 2017

Some details added.

@quintanilhar
Copy link
Contributor

Hey @kiwiz, could I get this issue?

@kiwiz
Copy link
Contributor Author

kiwiz commented Oct 30, 2017

Yup, assigned to you! Hmm, you don't show up on the list of assignable users. 🤷‍♂️

@kiwiz kiwiz removed their assignment Oct 30, 2017
@quintanilhar
Copy link
Contributor

It's weird, in the #145 you did. Anyway, I'm working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants