Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: apply engine api changes for devnet 8 #2896

Merged
merged 5 commits into from
Jul 21, 2023
Merged

client: apply engine api changes for devnet 8 #2896

merged 5 commits into from
Jul 21, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jul 18, 2023 •
edited
Loading

pending tasks to make client devnet 8 compatible

Could have further changes depending on the acceptance of
- ethereum/consensus-specs#3454

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #2896 (cf92f9f) into master (d19ee0e) will increase coverage by 0.09%.
The diff coverage is 95.14%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <ø> (ø)
blockchain 92.58% <ø> (ø)
client 88.45% <95.14%> (+0.15%) ⬆️
common 97.13% <ø> (ø)
ethash ∅ <ø> (∅)
evm 69.95% <ø> (ø)
statemanager 85.16% <ø> (ø)
trie 90.56% <ø> (ø)
tx 95.96% <ø> (ø)
util 86.77% <ø> (ø)
vm 78.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech added PR state: WIP package: client target: master Work to be done towards master branch labels Jul 18, 2023
@acolytec3 acolytec3 mentioned this pull request Jul 21, 2023
Closed
acolytec3
acolytec3 previously requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think one error message needs to be updated but will let you confirm.

packages/client/src/rpc/modules/engine.ts Outdated Show resolved Hide resolved
@g11tech
Copy link
Contributor Author

g11tech commented Jul 21, 2023

Looks good! I think one error message needs to be updated but will let you confirm.

thank yea updated, gtg for merge now :)

g11tech
g11tech commented Jul 21, 2023
View reviewed changes
packages/client/test/rpc/engine/newPayloadV3.spec.ts

describe(`${method}: call with executionPayloadV1`, () => {
it('call with invalid block hash without 0x', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests which are repeat of older versions have been removed

@holgerd77
Copy link
Member

Client tests failing, is this this timeout thing?

@g11tech
Copy link
Contributor Author

g11tech commented Jul 21, 2023

Client tests failing, is this this timeout thing?

yea seems like it 🙂

holgerd77
holgerd77 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit a616ca0 into master Jul 21, 2023
41 checks passed
@holgerd77 holgerd77 deleted the devnet8-engine branch July 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

@acolytec3 acolytec3 acolytec3 left review comments

Assignees
No one assigned
Labels
package: client PR state: merge ready target: master Work to be done towards master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g11tech @holgerd77 @acolytec3