Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine API: employ one method one structure approach for V3 #418

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

mkalinin
Copy link
Collaborator

@mkalinin mkalinin commented Jun 6, 2023

This change switched V3 methods to one method - one structure approach that we have agreed upon in the recent ACDC.

This PR enforces EL client to check that parameters and their fields in newPayloadV3 aren't null and makes the client to respond with error otherwise. Also, a similar validation is applied to the timestamp being greater or equal to 4844 activation. This enforcement can protect us from bugs like when CL attempts to send an old payload structure and EL accepts it. Happy to hear more inputs on that.

EDIT: A new -38005: Unsupported fork error is introduced to surface the case when a payload is from a fork that is not supported by a method e.g. Shanghai payload is submitted via newPayloadV3 which minimal supported fork is Cancun.

@Joshubb444
Copy link

Thanks

@Joshubb444
Copy link

Well done

1 similar comment
@Joshubb444
Copy link

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants