Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct boot support from esp-hal #903

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Remove direct boot support from esp-hal #903

merged 2 commits into from
Nov 7, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Nov 6, 2023 •
edited

Goodnight, sweet prince.

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

Closes #803

@MabezDev MabezDev mentioned this pull request Nov 6, 2023
Closed
bjoernQ
bjoernQ approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good to see so many linker scripts vanish

@MabezDev MabezDev merged commit fb31f86 into esp-rs:main Nov 7, 2023
17 checks passed
@MabezDev MabezDev deleted the remove-direct-boot branch November 7, 2023 14:34
@MabezDev MabezDev mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham Awaiting requested review from jessebraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Remove direct-boot support?
2 participants
@MabezDev @bjoernQ