Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/log): Remove formatting of log messages in ConsoleLogger #2408

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Aug 27, 2024

Why

Browser console did not format correctly objects

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 177c7d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@equinor/fusion-log Minor
@equinor/fusion-query Patch
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-module-app Patch
@equinor/fusion-framework-module-bookmark Patch
@equinor/fusion-framework-module-context Patch
@equinor/fusion-framework-module-service-discovery Patch
@equinor/fusion-framework-module-widget Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-react-module-context Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-module-signalr Patch
@equinor/fusion-framework-react-widget Patch
@equinor/fusion-framework-widget Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
@equinor/fusion-framework-react-module-signalr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🛠️ utils packages related to utils labels Aug 27, 2024
@odinr odinr force-pushed the fix/utility/logger/remove-message-formatting branch from e073274 to e9f75a3 Compare August 27, 2024 10:23
@odinr odinr marked this pull request as ready for review August 27, 2024 10:23
@odinr odinr requested a review from a team as a code owner August 27, 2024 10:23
Copy link
Contributor

@eikeland eikeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error in packages/utils/log/tests/ConsoleLogger.test.ts

@github-actions github-actions bot marked this pull request as draft August 27, 2024 10:54
@odinr odinr force-pushed the fix/utility/logger/remove-message-formatting branch from 91304ce to 177c7d6 Compare August 27, 2024 10:58
@odinr odinr marked this pull request as ready for review August 27, 2024 11:02
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.44% 1633 / 366919
🔵 Statements 0.44% 1633 / 366919
🔵 Functions 23.58% 209 / 886
🔵 Branches 36.66% 374 / 1020
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/utils/log/src/ConsoleLogger.ts 100% 94.44% 100% 100%
Generated in workflow #7255

@odinr odinr merged commit 3238800 into main Aug 27, 2024
12 checks passed
@odinr odinr deleted the fix/utility/logger/remove-message-formatting branch August 27, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🛠️ utils packages related to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants