Skip to content

Commit

Permalink
fix(utils/log): Refactor ConsoleLogger to improve title formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
odinr committed Aug 27, 2024
1 parent 779adf6 commit 177c7d6
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
9 changes: 7 additions & 2 deletions packages/utils/log/src/ConsoleLogger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,13 @@ export class ConsoleLogger extends Logger {
}

protected _formatTitle(_lvl: LogLevel): string {
const title = [this.title, this.subtitle].filter((x) => !!x).join(' - ');
return chalk.magenta(title);
const title = chalk.magenta([this.title, this.subtitle].filter((x) => !!x).join(' - '));
switch (_lvl) {
case LogLevel.Warning:
case LogLevel.Error:
return chalk.bold(title);
}
return title;
}

/**
Expand Down
11 changes: 8 additions & 3 deletions packages/utils/log/tests/ConsoleLogger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ describe('Console logger', () => {
logger.level = LogLevel.Debug;
logger.debug('This is a debug message');
expect(spy).toHaveBeenCalledWith(
chalk.dim(chalk.magenta('MainLogger'), 'This is a debug message'),
chalk(chalk.magenta('MainLogger')),
'This is a debug message',
);
});
it('should log info messages', () => {
Expand All @@ -28,7 +29,8 @@ describe('Console logger', () => {
logger.level = LogLevel.Warning;
logger.warn('This is a warning message');
expect(spy).toHaveBeenCalledWith(
chalk.bold(chalk.magenta('MainLogger'), 'This is a warning message'),
chalk.bold.magenta('MainLogger'),
'This is a warning message',
);
});

Expand All @@ -37,7 +39,10 @@ describe('Console logger', () => {
const logger = new ConsoleLogger('MainLogger');
logger.level = LogLevel.Error;
logger.error('This is an error message');
expect(spy).toHaveBeenCalledWith(chalk.magenta('MainLogger'), 'This is an error message');
expect(spy).toHaveBeenCalledWith(
chalk.bold.magenta('MainLogger'),
'This is an error message',
);
});

it('should log multiple messages', () => {
Expand Down

0 comments on commit 177c7d6

Please sign in to comment.