Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preflight error when suite-setup-util fails #1433

Merged
merged 2 commits into from
May 18, 2023
Merged

Make preflight error when suite-setup-util fails #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fcb927
Make preflight error when suite-setup-util fails
NullVoxPopuli May 18, 2023
82d20d1
use correct name for skipping engine scenarios
NullVoxPopuli May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
run: pnpm lint
- id: set-matrix
working-directory: test-packages/support
run: echo "matrix=$(node ./suite-setup-util.js --matrix)" >> $GITHUB_OUTPUT
run: |
matrix_json=$(node ./suite-setup-util --matrix)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separating these allows potential errors to halt CI (see first commit's red status)

echo "matrix=$matrix_json" >> $GITHUB_OUTPUT

test:
needs: ['preflight']
Expand Down
2 changes: 1 addition & 1 deletion tests/scenarios/engines-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ engineScenarios
});

engineScenarios
.skip('release') // fails due to https://github.com/emberjs/ember.js/pull/20461
.skip('release-engines') // fails due to https://github.com/emberjs/ember.js/pull/20461
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release doesn't exist -- but release-engines does!

.map('with-fastboot', app => {
app.linkDependency('ember-cli-fastboot', { baseDir: __dirname });
app.linkDependency('fastboot', { baseDir: __dirname });
Expand Down