-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make preflight error when suite-setup-util fails #1433
Make preflight error when suite-setup-util fails #1433
Conversation
@@ -34,7 +34,9 @@ jobs: | |||
run: pnpm lint | |||
- id: set-matrix | |||
working-directory: test-packages/support | |||
run: echo "matrix=$(node ./suite-setup-util.js --matrix)" >> $GITHUB_OUTPUT | |||
run: | | |||
matrix_json=$(node ./suite-setup-util --matrix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separating these allows potential errors to halt CI (see first commit's red status)
@@ -117,7 +117,7 @@ engineScenarios | |||
}); | |||
|
|||
engineScenarios | |||
.skip('release') // fails due to https://github.com/emberjs/ember.js/pull/20461 | |||
.skip('release-engines') // fails due to https://github.com/emberjs/ember.js/pull/20461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release
doesn't exist -- but release-engines
does!
All scenarios are green. 🎉 |
Thanks, good fixes. |
Resolves issue discovered here: https://github.com/embroider-build/embroider/actions/runs/5008028889