Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember serve fails on windows with embroider 0.32+ #681

Closed
mkszepp opened this issue Feb 6, 2021 · 1 comment · Fixed by #742
Closed

Ember serve fails on windows with embroider 0.32+ #681

mkszepp opened this issue Feb 6, 2021 · 1 comment · Fixed by #742

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Feb 6, 2021

The Embroider Version 0.32.0 and above is not working on windows after command ember s:
Version 0.31.0 works without problems

The problem also exists on a new ember project.

OS: Windows 10 x64
Ember Cli: 3.24.0
Embroider: 0.32.0 - 0.37.0

Steps to reproduce:

  1. npm install -g ember-cli
  2. ember new test-app
  3. npm i @embroider/core @embroider/compat @embroider/webpack
  4. Edit ember-cli-build.js like specified in Readme.md
  5. ember s

Build Error:


Module build failed (from C:/Projects/test-app/node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
[BABEL] $TMPDIR\embroider\8279ea\assets\test-app.js: module.call is not a function (While processing: "C:\\Projects\\test-app\\node_modules\\@embroider\\core\\src\\portable-babel-launcher.js")

    at babelLauncher (C:\Projects\test-app\node_modules\@embroider\core\src\portable-babel-launcher.js:18:25)
    at C:\Projects\test-app\node_modules\@babel\core\lib\config\full.js:211:14
    at Generator.next (<anonymous>)
    at Function.<anonymous> (C:\Projects\test-app\node_modules\@babel\core\lib\gensync-utils\async.js:26:3)
    at Generator.next (<anonymous>)
    at step (C:\Projects\test-app\node_modules\gensync\index.js:261:32)
    at evaluateAsync (C:\Projects\test-app\node_modules\gensync\index.js:291:5)
    at Function.errback (C:\Projects\test-app\node_modules\gensync\index.js:113:7)
    at errback (C:\Projects\test-app\node_modules\@babel\core\lib\gensync-utils\async.js:70:18)
    at async (C:\Projects\test-app\node_modules\gensync\index.js:188:31)


Stack Trace and Error Report: C:\Users\XXXXXX\AppData\Local\Temp/error.dump.dbfe1eeb8cfd0c70330d1e42d4579062.log```
@lifeart
Copy link
Collaborator

lifeart commented Feb 6, 2021

#676 may be related

thoov added a commit to thoov/embroider that referenced this issue Mar 26, 2021
Fixes: embroider-build#681 & embroider-build#676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
rwjblue pushed a commit to thoov/embroider that referenced this issue Mar 29, 2021
Fixes: embroider-build#681 & embroider-build#676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
thoov added a commit to thoov/embroider that referenced this issue Mar 29, 2021
Fixes: embroider-build#681 & embroider-build#676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
@ef4 ef4 closed this as completed in #742 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants