Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild not working with ember-intl (translation file changes will be ignored) #718

Closed
mkszepp opened this issue Mar 11, 2021 · 2 comments
Closed

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Mar 11, 2021

When i add/edit a translation file from ember-intl (example: my-project/translations/en.json) the rebuild is not starting.
There is always necessary to stop an restart the ember s.

No errors in output.

Tested on Linux + Windows

OS: Linux
Ember Cli: 3.25.2
Embroider: 0.37.0
Ember Intl: 5.6.2

OS: Windows 10 x64
Ember Cli: 3.25.2
Embroider: 0.29.0 (newer version are not working on windows - see #681)
Ember Intl: 5.6.2

Steps to reproduce:

  1. npm install -g ember-cli
  2. ember new test-app
  3. npm i @embroider/core @embroider/compat @embroider/webpack
  4. edit ember-cli-build.js (specified in Readme.md)
  5. ember install ember-intl + required file changes (see ember-intl quickstart)
  6. ember s
  7. modify a translation file
@ef4
Copy link
Contributor

ef4 commented Mar 11, 2021

It looks like ember-intl considers your translations part of itself (they live inside it's own module namespace instead of the app's).

Try setting the environment variable EMBROIDER_REBUILD_ADDONS=ember-intl. That will probably work around this problem.

ember-intl should consider refactoring so that translations stay in the app's module namespace.

@mkszepp
Copy link
Contributor Author

mkszepp commented Mar 12, 2021

@ef4 thank you, i can confirm, that the work around solves the problem.

@mkszepp mkszepp closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants