[FEATURE ember-glimmer-angle-bracket-built-ins] enable 👌 #17811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
requested review from
locks,
chadhietala,
dgeb,
ef4,
igorT,
jenweber,
kategengler,
krisselden,
MelSumner,
mixonic,
pzuraq,
rwjblue,
tomdale,
wycats and
a team
and removed request for
a team
wycats
approved these changes
Mar 28, 2019
chancancode
added a commit
that referenced
this pull request
Mar 28, 2019
Add missing dependent key There are no failing tests for this at the moment, because we only test with all optional features on or off. It turns out that the tracked property feature is masking this failure. As a result, the PR that enables this feature (#17811) without tracked property has some failing tests which should be green again after rebasing on top of this patch.
chadhietala
approved these changes
Mar 28, 2019
chancancode
force-pushed
the
enable-builtin-angles
branch
from
e5ea359
to
1c8e80c
Compare
chancancode
force-pushed
the
enable-builtin-angles
branch
from
1c8e80c
to
cfc2532
Compare
Fix events test
wycats
force-pushed
the
enable-builtin-angles
branch
from
628af51
to
e3818f7
Compare
|
We agreed to enable this feature on the framework core team meeting today. |
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Guides(being worked on in the Octane branch, tracked here)