Update docs for the builtin components #17810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
reviewed
Mar 27, 2019
| * form | ||
|
|
||
| When invoked with `{{input type="checkbox"}}`, you can only customize these attributes. When | ||
| invoked with `<Input @type="checkbox" />`, you can just use HTML attributes directly. |
There was a problem hiding this comment.
This is somewhat confusing, because it seems to suggest you can do <Input type="checkbox" />
chancancode
reviewed
Mar 27, 2019
|
|
||
| ```handlebars | ||
| Search: | ||
| {{input value=searchWord}} | ||
| ``` | ||
| <Input @value={{this.searchWord}}>` |
chancancode
reviewed
Mar 27, 2019
| }); | ||
| ``` | ||
| In most cases, if you want to pass an attribute to the underlying HTML `<input>` element, you | ||
| can pass the attribute directly, just like any other Ember component. |
There was a problem hiding this comment.
A short example would be good here
chancancode
reviewed
Mar 27, 2019
| element. When left unquoted, these values will be bound to a property on the | ||
| template's current rendering context (most typically a controller instance). | ||
| A very common use of this helper is to bind the `value` of an input to an Object's attribute: | ||
| If no `type` argument is specified, a default of type 'text' is used. |
There was a problem hiding this comment.
do we want to say @type here?
There was a problem hiding this comment.
You suggested to me to remove the @s 😛
chancancode
reviewed
Mar 27, 2019
|
|
||
| ### Extending `TextField` | ||
|
|
||
| Internally, `<Input @type="text" />` creates an instance of `TextField`, passing arguments from |
chancancode
reviewed
Mar 27, 2019
| classNames: ['my-app-checkbox'] | ||
| }); | ||
| ``` | ||
| Internally, `<Input @type="checkbox" />` creates an instance of `Ember.Checkbox` |
There was a problem hiding this comment.
Does this need the same text as above?
chancancode
reviewed
Mar 27, 2019
|
|
||
| See more about [Ember components](/api/ember/release/classes/Component) | ||
| /** | ||
| See Ember.Templates.components.Textarea. |
There was a problem hiding this comment.
Seems like this is missing a link
chancancode
reviewed
Mar 27, 2019
|
|
||
| Because HTML `textarea` elements do not contain inner HTML the `layout` and | ||
| `layoutName` properties will not be applied. | ||
| The internal representation used for `Textarea` invocations. | ||
|
|
||
| @class TextArea |
There was a problem hiding this comment.
did this get associated to @ember/component/text-area correctly? does it need a @for or something
chancancode
approved these changes
Mar 27, 2019
This was referenced Mar 28, 2019
|
Looks like the CI failure is needing to add these to |
wycats
force-pushed
the
update-builtin-component-docs
branch
from
21776ca
to
0cc0047
Compare
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.