Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-test-helpers and node #1077

Merged
merged 13 commits into from
Jun 10, 2023

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Jun 2, 2023

If merged, this PR updates ember-test-helpers to 3.0.2 (including peer dep declaration).

Details:

  • removes ember-lts-3.28 from ember-try scenario
  • fixes a typo in addon-test-support/adapter.js
  • adds @ember/string v3.1.1
  • updates @ember/test-helpers to v3.0.3
  • updates ember-source to >=4.0.0
  • drops node 14
  • updates node and yarn versions for volta
  • removes unused imports in types/tests.ts
  • updates types/tests.ts to use async/await instead of RenderingTestContext (deprecated)

@NullVoxPopuli
Copy link
Sponsor Collaborator

I'd like to merge these PRs first https://github.com/emberjs/ember-qunit/pulls/@me
all the PR descriptions can give context, and the needed breaking changes are throughout the PRs.

@gilest
Copy link

gilest commented Jun 7, 2023

I'd like to merge these PRs first

This link might work better for people who aren't you 😅 https://github.com/emberjs/ember-qunit/pulls/NullVoxPopuli

Unless I'm mistaken this will be blocked until Node 14 support is dropped

@NullVoxPopuli
Copy link
Sponsor Collaborator

Whoops, thanks!

@MelSumner
Copy link
Contributor Author

MelSumner commented Jun 8, 2023

Right, so, my plan is to do two releases:

  1. drop old node, upgrade ember-test-helpers version, release new major
  2. merge in the PRs from @NullVoxPopuli then do a new major after that

This is BECAUSE of all the issues we faced with ember-test-helpers, it feels a little more pragmatic to do it this way. BUT I am running into issues just trying to do this first one so we'll see. If I can't resolve it soon I'll consider a different approach.

@MelSumner MelSumner changed the title upgrades ember-test-helpers to 3.0.2 Upgrade ember-test-helpers and node Jun 8, 2023
types/tests.ts Outdated Show resolved Hide resolved
types/tests.ts Outdated Show resolved Hide resolved
@NullVoxPopuli
Copy link
Sponsor Collaborator

looks like @ember/string needs to be added to the test app

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@@ -83,12 +83,12 @@
"webpack": "^5.75.0"
},
"peerDependencies": {
"@ember/test-helpers": "^2.9.3",
"ember-source": ">=3.28",
"@ember/test-helpers": ">=3.0.3",
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making notes for release,
we're dropping support for:

  • @ember/test-helpers < 3.0.3
  • ember-source < 4
  • node < 16
  • this.element -- folks should use qunit.dom or [data-test-whatever] and find
  • this.render -- await render is easy find and replace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this.render, folks would need to remember to async function (assert) + await render

Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, something to call out in the changelog

types/tests.ts Show resolved Hide resolved
@NullVoxPopuli NullVoxPopuli mentioned this pull request Jun 9, 2023
@MelSumner MelSumner marked this pull request as ready for review June 9, 2023 21:48
@MelSumner MelSumner added internal dependencies Pull requests that update a dependency file labels Jun 9, 2023
@MelSumner MelSumner requested review from a team and NullVoxPopuli and removed request for NullVoxPopuli June 10, 2023 00:17
@MelSumner MelSumner merged commit 07aa3ca into master Jun 10, 2023
@MelSumner MelSumner deleted the melsumner/update-ember-test-helpers branch June 10, 2023 01:47
@MelSumner MelSumner mentioned this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants