-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @ember/test-helpers to 3.x #509
Upgrade @ember/test-helpers to 3.x #509
Conversation
fd5238b
to
ff62a0b
Compare
I think there might be some changes to make related to what was merged in #503 |
720451d
to
4fb00bc
Compare
4fb00bc
to
f83d220
Compare
It looks like this is blocked on We'll need emberjs/ember-qunit#1077 and a new release of ember-qunit first (as @MelSumner pointed out in a slack conversation with me at work).
It looks like the first time I made the commit I used a newer yarn which significantly changed the lock file. I reverted back to the version in |
The README should be updated as part of this PR to tell users what version of the addon to use if they need to support Node 14. |
49527a7
to
39ac860
Compare
49bff93
to
87ebada
Compare
8091178
to
f7a8ecc
Compare
8b7e05a
to
efc5208
Compare
Co-authored-by: Melanie Sumner <melanie.sumner@hey.com>
Co-authored-by: Melanie Sumner <melanie.sumner@hey.com>
@@ -115,7 +117,7 @@ start(); | |||
|
|||
:warning: It's important to note that you must also use the [`enableA11yAudit`](#force-running-audits) query parameter in order to force audits. This setting is required in addition to any invocation strategy you provide. | |||
|
|||
By default, audits will be run on `visit`, `click`, `doubleClick`, and `tap`. To add additional helpers to hook into, specify them by name in the `options.helpers` argument. Note that this option specifies the *complete* set of helpers to hook into; to include the defaults you must import them and splat them into the array as shown below. | |||
By default, audits will be run on `visit`, `click`, `doubleClick`, and `tap`. To add additional helpers to hook into, specify them by name in the `options.helpers` argument. Note that this option specifies the _complete_ set of helpers to hook into; to include the defaults you must import them and splat them into the array as shown below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes were unintentional but ran since I have the prettier plugin enabled in VSCode. Should we leave the changes in and figure out how to have prettier check .md
files in CI in a different PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it's fine to leave them in, can you create an issue to track this though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0722b0d
to
9bbec9e
Compare
9bbec9e
to
2844fbc
Compare
@@ -32,7 +32,7 @@ jobs: | |||
run: yarn test:node | |||
|
|||
floating: | |||
name: "Floating Dependencies" | |||
name: 'Floating Dependencies' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a change from prettier
I'm going to try a pre-release for this so we can see how it works |
depends upon #508
partially resolves #506
@ember/test-helpers
to^3.x
.@ember/test-helpers
. https://github.com/emberjs/ember-test-helpers/blob/92392b110565de201729037b8469362dea1bb472/addon/package.json#L106