Do not compute FastBootService.request in the browser #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjansingh
changed the title
| @@ -1,7 +1,7 @@ | |||
| /* global FastBoot */ | |||
| import Ember from "ember"; | |||
|
|
|||
| const { deprecate, computed, get } = Ember; | |||
| const { deprecate, computed, get, set } = Ember; | |||
There was a problem hiding this comment.
nowhere after my last refactor. good catch!
|
Updated to remove |
|
@danmcclain any other blockers to merging? |
| import { moduleFor, test } from 'ember-qunit'; | ||
|
|
||
| moduleFor('service:fastboot', 'Unit | Service | fastboot in the browser', { | ||
| // Specify the other units that are required for this test. |
There was a problem hiding this comment.
Don't need these comment lines
xg-wang
pushed a commit
to xg-wang/ember-cli-fastboot
that referenced
this pull request
Nov 16, 2020
…-sync Remove usage of deprecated exists-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danmcclain Whenever
FastBootService.requestwas accessed in the browser, it was not handling_fastbootInfo.requestbeingundefined. This fix ensures that we returnnullin that case just likeEmber.computed.readOnlywould.