Merge pull request #201 from arjansingh/error

Do not compute FastBootService.request in the browser
ember-fastboot · May 31, 2016 · 377748d · 377748d
2 parents 121aa03 + 60690b4
commit 377748d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/app/services/fastboot.js b/app/services/fastboot.js
@@ -84,6 +84,7 @@ export default Ember.Service.extend({
   response: readOnly('_fastbootInfo.response'),
 
   request: computed(function() {
+    if (!get(this, 'isFastBoot')) return null;
     return RequestObject.create({ request: get(this, '_fastbootInfo.request') });
   }),
 

diff --git a/tests/unit/services/fastboot-test.js b/tests/unit/services/fastboot-test.js
@@ -0,0 +1,18 @@
+import { moduleFor, test } from 'ember-qunit';
+
+moduleFor('service:fastboot', 'Unit | Service | fastboot in the browser', {});
+
+test('isFastBoot', function(assert) {
+  let service = this.subject();
+  assert.equal(service.get('isFastBoot'), false, `it should be false`);
+});
+
+test('request', function(assert) {
+  let service = this.subject();
+  assert.equal(service.get('request'), null, `it should be null`);
+});
+
+test('response', function(assert) {
+  let service = this.subject();
+  assert.equal(service.get('response'), null, `it should be null`);
+});