Fastboot does not run with Babel browser polyfill

[topaxi]

Trying to run fastboot (master) with the babel-browser-polyfill crashes with:

TypeError: Cannot read property 'prototype' of undefined
    at Object.58../$ (<anonymous>:2132:25)
    at s (<anonymous>:13:255)
    at <anonymous>:13:306
    at Object.93../modules/$ (<anonymous>:3269:1)
    at s (<anonymous>:13:255)
    at <anonymous>:13:306
    at Object.<anonymous> (<anonymous>:21:1)
    at Object.1../tools/protect.js (<anonymous>:33:4)
    at s (<anonymous>:13:255)
    at e (<anonymous>:13:426)

My ember-cli-build.js looks roughly like this:

var EmberApp = require('ember-cli/lib/broccoli/ember-app')

module.exports = function(defaults) {
  var app = new EmberApp(defaults, {
    babel: {
      optional: [ 'es7.asyncFunctions' ]
    }
  })

  app.import('vendor/babel-polyfill.js', { prepend: true })

  return app.toTree()
}

I'm not experienced enough with fastboot and contextify to debug this.

[tomdale]

Probably related to #57. I'm assuming based on the name that babel-browser-polyfill relies on browser features that aren't available in Node.

[tomdale]

@topaxi Surely there's a version of the Babel polyfill designed to work in Node? Do you know which line you're getting the exception from?

[tomdale]

Any idea @thejameskyle?

[jamiebuilds]

@tomdale The only difference between the "node" polyfill and the "browser" one is that the browser one has been compiled with browserify. So it should be working fine.

@topaxi Can you share the code that is causing this error?

[topaxi]

I setup a minimal clean repository here: https://github.com/topaxi/fastboot-test
(Edit: I accidentally amended instead of creating a new commit on top of the ember created commit...)

All I did was:

ember new fastboot-test
ember install tildeio/ember-cli-fastboot#master
cp node_modules/ember-cli-babel/node_modules/broccoli-babel-transpiler/node_modules/babel-core/browser-polyfill.js vendor/babel-browser-polyfill.js

And updated the ember-cli-build.js and then ran:

ember fastboot

Which leads to:

version: 1.13.8
Could not find watchman, falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
Built project successfully. Stored in "fastboot-dist".
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
Cannot read property 'prototype' of undefined
TypeError: Cannot read property 'prototype' of undefined
    at Object.56../$ (<anonymous>:1906:25)
    at s (<anonymous>:13:255)
    at <anonymous>:13:306
    at Object.91../modules/$ (<anonymous>:3043:1)
    at s (<anonymous>:13:255)
    at <anonymous>:13:306
    at Object.<anonymous> (<anonymous>:109:1)
    at Object.2.core-js/shim (<anonymous>:117:4)
    at s (<anonymous>:13:255)
    at e (<anonymous>:13:426)

Tested using iojs 2.4.0 and nodejs 0.12.4

[jamiebuilds]

Could you just like share the code that's causing the error in like a code snippet? I'm on a phone and a whole repo is not very minimal.

[topaxi]

I'm not a 100% sure, but I think it is here: https://github.com/topaxi/fastboot-test/blob/master/vendor/babel-browser-polyfill.js#L1894

// ...
},{"./$.def":13}],56:[function(require,module,exports){
'use strict';
var $          = require('./$')
  , isObject   = $.isObject
  , isFunction = $.isFunction
  , NUMBER     = 'Number'
  , $Number    = $.g[NUMBER]
  , Base       = $Number
  , proto      = $Number.prototype; // <- This line right here!
function toPrimitive(it){
  var fn, val;
  if(isFunction(fn = it.valueOf) && !isObject(val = fn.call(it)))return val;
  if(isFunction(fn = it.toString) && !isObject(val = fn.call(it)))return val;
  throw TypeError("Can't convert object to number");
}
// ...

[tomdale]

@topaxi Have you had a chance to look into this more?

[tomdale]

Gonna close due to inactivity. Please continue the conversation if there are more details.