Skip to content

Commit

Permalink
Merge pull request ember-fastboot#55 from ember-fastboot/deprecate-do…
Browse files Browse the repository at this point in the history
…cument-title

Deprecate setting title via `document.title`
  • Loading branch information
tomdale committed May 9, 2016
2 parents a12c93e + 7643c7c commit 4af310d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ FastBootServer.prototype.insertIntoIndexHTML = function(title, body, head) {
var html = this.html.replace("<!-- EMBER_CLI_FASTBOOT_BODY -->", body);

if (title) {
this.ui.writeDeprecateLine('`document.title` (via SimpleDom) is deprecated, please use `ember-cli-head` to insert a title into the `<head>` tag');
html = html.replace("<!-- EMBER_CLI_FASTBOOT_TITLE -->", "<title>" + title + "</title>");
}
if (head) {
Expand Down

0 comments on commit 4af310d

Please sign in to comment.