Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Node reference when using ember canary #258

Closed
bantic opened this issue Sep 6, 2016 · 1 comment
Closed

Unexpected Node reference when using ember canary #258

bantic opened this issue Sep 6, 2016 · 1 comment

Comments

@bantic
Copy link
Contributor

bantic commented Sep 6, 2016

(Note: In order to discover this issue I had to first comment out the dom-helper-patches that are mentioned in #255).

When running ember fastboot with ember version 2.9.0-alpha.4 and ember-cli-fastboot version 1.0.0-beta.8, an error occurs during page rendering when the Ember code attempts to access Node.DOCUMENT_FRAGMENT_NODE. This comes from glimmer's dom-helper#isDocumentFragment method. This appears like it may be an oversight in glimmer. There is a node-dom-helper.ts file that may be intended to be used by fastboot instead, but it isn't part of the ember build afaict.

edit: fix linked issue number from 225->255

@bantic
Copy link
Contributor Author

bantic commented Sep 6, 2016

This actually works fine if you use the latest ember alpha (bower install ember#alpha), so the issue is likely fixed somewhere between 2.9.0-alpha.4 and master.

@bantic bantic closed this as completed Sep 6, 2016
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant