Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing Node global in dom-helpers causes issue with ember-cli-fastboot #300

Closed
bantic opened this issue Sep 6, 2016 · 3 comments
Closed

Comments

@bantic
Copy link
Contributor

bantic commented Sep 6, 2016

See relevant issue at ember-cli-fastboot: ember-fastboot/ember-cli-fastboot#258

Referencing Node.DOCUMENT_FRAGMENT_TYPE in dom-helper's isDocumentFragment method causes an issue when rendering an ember app using ember canary (2.9.0-alpha.4) and ember-cli-fastboot (1.0.0-beta.8) because the global Node is not available in the Node.js environment.

I'm not certain if this is an oversight in glimmer, or if something else should be happening to make it so that ember-cli-fastboot is using the exports from node-dom-helper.ts instead.

@chancancode
Copy link
Contributor

@bantic can you test with the latest alpha build (bower install ember#alpha)? (alpha 4 is pretty old)

Thank you!

@bantic
Copy link
Contributor Author

bantic commented Sep 6, 2016

@chancancode Thanks for the suggestion. Yes, this works fine with ember#alpha, so it must be fixed there. thank you!

@bantic bantic closed this as completed Sep 6, 2016
@chancancode
Copy link
Contributor

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants