Remove left over "refresh index pattern" message from Discover #85018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Feature:Discover
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededMetrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: |
majagrubic
approved these changes
Dec 4, 2020
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Dec 5, 2020
…ic#85018) * Remove the unmapped field refresh warning * Remove unneeded translations * Remove old imports
timroes
pushed a commit
that referenced
this pull request
Dec 6, 2020
… (#85092) * Remove the unmapped field refresh warning * Remove unneeded translations * Remove old imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of #82223 the field cache in index patterns no longer exists. This removes the warning from Discover for unmapped fields that the user should refresh their index pattern.
We also decided not to show another message, since showing unmapped fields will be gone in the future from discover (since we want to make usage of the fields API), thus we'll simply not show this message.
This also solves the issue that the message shows in a couple of invalid cases (like parent nested fields)... since it's gone now.
Checklist
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)[ ] This was checked for cross-browser compatibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately