Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli/dev] make optimizer delays more obvious and hide proxy target url #84835

Merged
merged 4 commits into from
Dec 7, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 2, 2020

Based on #84726
Fixes #80923

Replaces the base path proxy url in the logging output with the front-end url, and logs when requests are held for over 1 second explaining why they are being delayed.

image

@spalger spalger force-pushed the dev-cli/make-waiting-more-obvious branch 2 times, most recently from f77cbc7 to 0dc3941 Compare December 2, 2020 23:27
@spalger spalger changed the title [cli/dev] remove cluster module, modernize, test [cli/dev] make optimizer delays more obvious and hide proxy target url Dec 3, 2020
@spalger spalger force-pushed the dev-cli/make-waiting-more-obvious branch from 0dc3941 to 76f57f3 Compare December 4, 2020 21:29
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0 labels Dec 4, 2020
@spalger spalger marked this pull request as ready for review December 4, 2020 21:30
@spalger spalger requested review from a team as code owners December 4, 2020 21:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger
Copy link
Contributor Author

spalger commented Dec 7, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 46897 47657 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit b01f33e into elastic:master Dec 7, 2020
@spalger spalger deleted the dev-cli/make-waiting-more-obvious branch December 7, 2020 18:35
@spalger
Copy link
Contributor Author

spalger commented Dec 7, 2020

Backporting in #85174

@spalger spalger added the backport:skip This commit does not require backporting label Dec 7, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request Dec 7, 2020
elastic#84835)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b01f33e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev/cli] Log about waiting for optimizer, hide proxy target URL
6 participants