-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli/dev] make optimizer delays more obvious and hide proxy target url #84835
Merged
spalger
merged 4 commits into
elastic:master
from
spalger:dev-cli/make-waiting-more-obvious
Dec 7, 2020
Merged
[cli/dev] make optimizer delays more obvious and hide proxy target url #84835
spalger
merged 4 commits into
elastic:master
from
spalger:dev-cli/make-waiting-more-obvious
Dec 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
dev-cli/make-waiting-more-obvious
branch
2 times, most recently
from
December 2, 2020 23:27
f77cbc7
to
0dc3941
Compare
spalger
changed the title
[cli/dev] remove cluster module, modernize, test
[cli/dev] make optimizer delays more obvious and hide proxy target url
Dec 3, 2020
spalger
force-pushed
the
dev-cli/make-waiting-more-obvious
branch
from
December 4, 2020 21:29
0dc3941
to
76f57f3
Compare
spalger
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.11.0
v8.0.0
labels
Dec 4, 2020
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbudz
approved these changes
Dec 4, 2020
pgayvallet
approved these changes
Dec 6, 2020
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
Backporting in #85174 |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 7, 2020
elastic#84835) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b01f33e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #84726
Fixes #80923
Replaces the base path proxy url in the logging output with the front-end url, and logs when requests are held for over 1 second explaining why they are being delayed.