[cli/dev] remove cluster module, modernize, test #84726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
afharo
reviewed
Dec 3, 2020
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
tylersmalley
reviewed
Dec 3, 2020
tylersmalley
reviewed
Dec 3, 2020
tylersmalley
reviewed
Dec 3, 2020
tylersmalley
reviewed
Dec 3, 2020
tylersmalley
approved these changes
Dec 3, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Dec 4, 2020
This was referenced Dec 7, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Dec 7, 2020
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84134
Closes #84131
Closes #83976
We've had a number of issues with the dev CLI lately, detailed in the issues above, and I really want to work on some improvements like #84555, but the legacy code has been a huge mess to deal with and is a complicated bundle of evented items which are tricky to manage. This PR attempts to address all these issues at once by rewriting the dev CLI as several observable components detailed in https://github.com/spalger/kibana/blob/dev-cli/remove-cluster-usage/src/dev/cli_dev_mode/README.md.
This PR moves us to using pipes to handle the stdout from the child process now, rather than passing our stdout/stderr handles to the Kibana server. This gives us the opportunity to mask the basePathProxy target URL and should reduce the likelihood of #84131 from coming back.