Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Cases] Move field mappings from actions to cases #84587

Merged
merged 87 commits into from
Dec 15, 2020
Merged

[Security Solution] [Cases] Move field mappings from actions to cases #84587

Show file tree
Hide file tree
Changes from 77 commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
566998c
rm fields from actions
stephmilovic Nov 9, 2020
94f2400
more removing
stephmilovic Nov 9, 2020
07ed164
fields on config page
stephmilovic Nov 9, 2020
8b0aa22
Merge branch 'master' into field-mappings-move
stephmilovic Nov 10, 2020
33838f9
mapping flyout ui
stephmilovic Nov 10, 2020
d2b3c9e
cases endpoint for formatting
stephmilovic Nov 10, 2020
7ceef94
returning common response from case ep
stephmilovic Nov 11, 2020
a026433
flyout ui
stephmilovic Nov 11, 2020
dddc74b
cleanup
stephmilovic Nov 11, 2020
7e0dab8
Merge branch 'master' into field-mappings-move
stephmilovic Nov 18, 2020
d3cf611
fix flyout ui
stephmilovic Nov 18, 2020
c509e07
wip, but did a nice type check clean
stephmilovic Nov 18, 2020
0eac5b6
trying to work server side but jeeez
stephmilovic Nov 18, 2020
5539c81
Merge branch 'master' into field-mappings-move
stephmilovic Nov 18, 2020
8c38c4a
tried adding enum
stephmilovic Nov 19, 2020
01cd4d9
Merge branch 'master' into field-mappings-move
stephmilovic Nov 19, 2020
ec37063
types and utils
stephmilovic Nov 19, 2020
2a60aec
help fix types
XavierM Nov 19, 2020
4853e24
merged w x
stephmilovic Nov 19, 2020
70bdf3f
fix types
stephmilovic Nov 19, 2020
7393604
more
stephmilovic Nov 20, 2020
c52a9db
im doing a great job
stephmilovic Nov 20, 2020
79d3530
moving formatting to server
stephmilovic Nov 20, 2020
a72e87e
well this is really messed up
stephmilovic Nov 20, 2020
24d1902
fixed types and a lot of other things omg this PR is a nightmare sorr…
stephmilovic Nov 23, 2020
c7bad49
its working damn it feels good to be a gangsta
stephmilovic Nov 24, 2020
a704094
need to fix ref to actions
stephmilovic Nov 24, 2020
b3fc2f2
fix icon
stephmilovic Nov 24, 2020
0bd0b27
cleanup
stephmilovic Nov 24, 2020
3e3d303
type cleanup
stephmilovic Nov 24, 2020
ba654b5
more type fixing
stephmilovic Nov 25, 2020
fa0d1cd
more cleanup
stephmilovic Nov 25, 2020
df63ea7
update jira_params to new type
stephmilovic Nov 25, 2020
9850c3e
actions _params refactor
stephmilovic Nov 26, 2020
0efed87
lots of jest test fixing
stephmilovic Nov 26, 2020
a5117d9
cleanup til monday
stephmilovic Nov 26, 2020
98c0db8
Merge branch 'master' into field-mappings-move
stephmilovic Nov 30, 2020
5758284
fix case jest tests
stephmilovic Nov 30, 2020
3e6bdeb
fixed first api test
stephmilovic Nov 30, 2020
9f8221d
fix api tests
stephmilovic Nov 30, 2020
3f16315
remove flyout
stephmilovic Nov 30, 2020
af6f357
fix conflicts
stephmilovic Dec 1, 2020
35a8986
fix CI things
stephmilovic Dec 1, 2020
4363a8d
cypress fix
stephmilovic Dec 1, 2020
400263c
readd check
stephmilovic Dec 1, 2020
dcb6477
resolve conflicts and fix types
stephmilovic Dec 1, 2020
44880d1
fix translations i hope
stephmilovic Dec 1, 2020
6a2b5fc
fix some json
stephmilovic Dec 1, 2020
f356830
yet more conflicts
stephmilovic Dec 1, 2020
6fbefee
Merge branch 'master' into field-mappings-move
kibanamachine Dec 1, 2020
578be8b
fix file refs
stephmilovic Dec 2, 2020
24828a4
Merge branch 'field-mappings-move' of github.com:stephmilovic/kibana …
stephmilovic Dec 2, 2020
e561f97
Merge branch 'master' into field-mappings-move
stephmilovic Dec 2, 2020
35ff36f
test fixes
stephmilovic Dec 2, 2020
2f21092
working on migrations
stephmilovic Dec 2, 2020
0f79fdf
wow this is a mess
stephmilovic Dec 2, 2020
678fefd
configure utils cleanup
stephmilovic Dec 3, 2020
cacc55b
rm logs
stephmilovic Dec 3, 2020
d201caa
rm only test
stephmilovic Dec 3, 2020
24c9cfa
bring in logs
stephmilovic Dec 3, 2020
28bf59f
Merge branch 'master' into field-mappings-move
stephmilovic Dec 3, 2020
28a9b70
logs
stephmilovic Dec 3, 2020
7aa12f6
fix migration test
stephmilovic Dec 4, 2020
79f5981
PR changes
stephmilovic Dec 4, 2020
28e1ed8
better error handling
stephmilovic Dec 4, 2020
9deed05
Merge branch 'master' into field-mappings-move
stephmilovic Dec 4, 2020
ec4fb37
Case dependency in security_solution
stephmilovic Dec 4, 2020
aa80858
pr updates
stephmilovic Dec 7, 2020
2fbb474
fix first actions bug
stephmilovic Dec 7, 2020
408e9a2
fix more actions bugs
stephmilovic Dec 8, 2020
33d1bea
working on conflict
stephmilovic Dec 8, 2020
7877186
fix actions bug
stephmilovic Dec 8, 2020
6d6fbc0
fix actions bug and broken test
stephmilovic Dec 9, 2020
6c63278
resolve merge conflict
stephmilovic Dec 9, 2020
c63f49c
rm unused methods
stephmilovic Dec 9, 2020
6a7b1bc
Merge branch 'master' into field-mappings-move
stephmilovic Dec 9, 2020
2612228
more aciton bug fix
stephmilovic Dec 9, 2020
786eaf5
Merge branch 'master' into field-mappings-move
cnasikas Dec 11, 2020
b783598
Fix bugs
cnasikas Dec 11, 2020
1d89e55
Merge branch 'master' into field-mappings-move
kibanamachine Dec 14, 2020
497bef5
Merge branch 'master' into field-mappings-move
stephmilovic Dec 14, 2020
3552e98
really best bug fixes
stephmilovic Dec 14, 2020
240bb50
merge w masteR
stephmilovic Dec 14, 2020
85900c1
better than best bug fixes
stephmilovic Dec 14, 2020
d550add
fix test
stephmilovic Dec 14, 2020
c1fadeb
fix bug with empty comments
stephmilovic Dec 15, 2020
da34416
Merge branch 'master' into field-mappings-move
kibanamachine Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dev/run_find_plugins_with_circular_deps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const allowedList: CircularDepList = new Set([
'src/plugins/vis_default_editor -> src/plugins/visualize',
'src/plugins/visualizations -> src/plugins/visualize',
'x-pack/plugins/actions -> x-pack/plugins/case',
'x-pack/plugins/case -> x-pack/plugins/security_solution',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistic security_solution has a hard dependency on case, and will until the case UI is removed out of security_solution. I believe the dependency should be included in this list

Copy link
Member

@mistic mistic Dec 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephmilovic we need to remove all the circular dependencies in order to move forward with #80508. We can add this item here but it will add up on more future work you'll need to do in order to assure we can move forward with ts project references. Can we open an issue to track the future removal of that circular dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an issue to fix our dependency on lists. I'll add one for cases as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it in just in time for planning :) https://github.com/elastic/security-team/issues/609

'x-pack/plugins/apm -> x-pack/plugins/infra',
'x-pack/plugins/lists -> x-pack/plugins/security_solution',
'x-pack/plugins/security -> x-pack/plugins/spaces',
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/actions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,6 @@ The ServiceNow action uses the [V2 Table API](https://developer.servicenow.com/a
| Property | Description | Type |
| --------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------- |
| apiUrl | ServiceNow instance URL. | string |
| incidentConfiguration | Optional property and specific to **Cases only**. If defined, the object should contain an attribute called `mapping`. A `mapping` is an array of objects. Each mapping object should be of the form `{ source: string, target: string, actionType: string }`. `source` is the Case field. `target` is the ServiceNow field where `source` will be mapped to. `actionType` can be one of `nothing`, `overwrite` or `append`. For example the `{ source: 'title', target: 'short_description', actionType: 'overwrite' }` record, inside mapping array, means that the title of a case will be mapped to the short description of an incident in ServiceNow and will be overwrite on each update. | object _(optional)_ |

### `secrets`

Expand Down Expand Up @@ -600,7 +599,6 @@ The Jira action uses the [V2 API](https://developer.atlassian.com/cloud/jira/pla
| Property | Description | Type |
| --------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------- |
| apiUrl | Jira instance URL. | string |
| incidentConfiguration | Optional property and specific to **Cases only**. if defined, the object should contain an attribute called `mapping`. A `mapping` is an array of objects. Each mapping object should be of the form `{ source: string, target: string, actionType: string }`. `source` is the Case field. `target` is the Jira field where `source` will be mapped to. `actionType` can be one of `nothing`, `overwrite` or `append`. For example the `{ source: 'title', target: 'summary', actionType: 'overwrite' }` record, inside mapping array, means that the title of a case will be mapped to the short description of an incident in Jira and will be overwrite on each update. | object _(optional)_ |

### `secrets`

Expand Down Expand Up @@ -653,7 +651,6 @@ ID: `.resilient`
| Property | Description | Type |
| --------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------ |
| apiUrl | IBM Resilient instance URL. | string |
| incidentConfiguration | Optional property and specific to **Cases only**. If defined, the object should contain an attribute called `mapping`. A `mapping` is an array of objects. Each mapping object should be of the form `{ source: string, target: string, actionType: string }`. `source` is the Case field. `target` is the Jira field where `source` will be mapped to. `actionType` can be one of `nothing`, `overwrite` or `append`. For example the `{ source: 'title', target: 'summary', actionType: 'overwrite' }` record, inside mapping array, means that the title of a case will be mapped to the short description of an incident in IBM Resilient and will be overwrite on each update. | object |

### `secrets`

Expand Down
7 changes: 0 additions & 7 deletions x-pack/plugins/actions/server/builtin_action_types/case/constants.ts
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions x-pack/plugins/actions/server/builtin_action_types/case/schema.ts
View file
Open in desktop

This file was deleted.

131 changes: 0 additions & 131 deletions x-pack/plugins/actions/server/builtin_action_types/case/transformers.test.ts
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions x-pack/plugins/actions/server/builtin_action_types/case/transformers.ts
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions x-pack/plugins/actions/server/builtin_action_types/case/translations.ts
View file
Open in desktop

This file was deleted.

54 changes: 0 additions & 54 deletions x-pack/plugins/actions/server/builtin_action_types/case/types.ts
View file
Open in desktop

This file was deleted.

Loading