[Security Solution] [Cases] Move field mappings from actions to cases #84587
Conversation
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
| }, [actionParams]); |
There was a problem hiding this comment.
need to run editAction with subActionParams on mount in order to run error validation, but setting both with deps of [] creates a race condition and only one gets set. by checking for undefined values whenever the actionParams change, we can overcome the race condition
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
cnasikas
added
the
release_note:plugin_api_changes
| }); | ||
| }; | ||
|
|
||
| export const transformFields = < |
There was a problem hiding this comment.
Here @elastic/security-threat-hunting is the start of the migration we didn't catch
| @@ -128,23 +72,13 @@ const pushToServiceHandler = async ({ | |||
| }); | |||
| } else { | |||
| res = await externalService.createIncident({ | |||
| incident: { | |||
There was a problem hiding this comment.
this is the start of the missed migration @elastic/security-threat-hunting
| comments = transformComments(caseComments, ['informationAdded']); | ||
| } | ||
| } | ||
| return { incident, comments }; |
There was a problem hiding this comment.
this is (part) of the end of the missed migration @elastic/security-threat-hunting
| } = params as JiraPushToServiceApiParams['incident']; | ||
| return { | ||
| incident: { priority, labels, issueType, parent }, | ||
| thirdPartyName: 'Jira', |
There was a problem hiding this comment.
this is (part) of the end of the missed migration @elastic/security-threat-hunting
Summary
Moves field mappings for case connectors (servicenow, jira, resilient) out of actions and into cases. Specifically:
incidentConfigurationandisCaseOwnedfrom the config schema in each connectorincidentConfigurationandisCaseOwnedfrom each action savedObject.types.tsfrom within the cases folder inside built in actions.cases-connector-mappingssecurity_solution(shown in gif below)builtin_action_types/case_mappingsfolder.Part 3 of 3 in dynamic mappings coming soon, then thorough testing.
Checklist
Delete any items that are not applicable to this PR.