[Usage Collection] [schema] Explicit "array" definition #78141

afharo · 2020-09-22T12:05:51Z

Summary

We want the usage collection schema to be declarative of the format that is reported by each registered usage collector. That's why we are adding a specific way to declare array properties.

Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-22T14:52:52Z

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

jportner

Code review only -- Security plugin changes LGTM!

elasticmachine · 2020-09-22T14:57:18Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2020-09-22T14:57:18Z

Pinging @elastic/ingest-management (Team:Ingest Management)

skh

Ingest Management changes look good, thank you! 👍

michaelolo24

Security Solution, changes look 💯. Thank you!

TinaHeiligers

Thank you for adding the array type! It will make it much easier to interpret what share the data is in.
LGTM

Bamieh · 2020-09-24T12:10:27Z

src/plugins/telemetry/schema/oss_plugins.json

@@ -44,7 +47,10 @@
          "type": "keyword"
        },
        "uninstalled": {
-          "type": "keyword"
+          "type": "array",
+          "items": {


What do you think about renaming items to properties?

I tried to follow similarities to the JSON-schema specification (even though we are not fully using that).

I think items or an array make more sense to me. They are not properties or the array.

But happy to change it if you think properties is the right way to go.

Bamieh · 2020-09-24T12:12:02Z

packages/kbn-telemetry-tools/src/tools/manage_schema.ts

@@ -28,7 +28,7 @@ export type AllowedSchemaTypes =
  | 'date'
  | 'float';

-export function compatibleSchemaTypes(type: AllowedSchemaTypes) {
+export function compatibleSchemaTypes(type: AllowedSchemaTypes | 'array') {


Why didnt we add array to the AllowedSchemaTypes type here instead of using union?

Because I think TS would allow { type: 'array' } for non-array fields and we'll only catch it when running the check.

afharo · 2020-09-24T13:07:29Z

@elasticmachine merge upstream

…inition

afharo · 2020-09-28T09:33:46Z

@elasticmachine merge upstream

…inition

shahzad31

LGTM Uptime changes !!

afharo · 2020-09-28T12:26:22Z

@elasticmachine merge upstream

…inition

kibanamachine · 2020-09-28T14:01:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: af5aa24

Metrics [docs]

✅ unchanged

History

💔 Build #77318 failed fd9d9bf
💚 Build #77324 succeeded 6c6e4b3
💔 Build #77310 failed 2044602
💚 Build #76912 succeeded 5a67615
💛 Build #76150 was flaky 39a8515

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

chrisronline

LGTM! Thanks!

#78618) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: Fix APM lodash imports (elastic#78438) Add deprecated message to tile_map and region_map visualizations. (elastic#77683) Fix Lens smokescreen flaky tests (elastic#78566) updated discover with alt text (elastic#77660) Fix types (elastic#78619) Update tutorial-visualizing.asciidoc (elastic#76977) Update tutorial-discovering.asciidoc (elastic#76976) [Search] Error notification alignment (elastic#77788) Update tutorial-define-index.asciidoc (elastic#76975) [Lens] Fieldless operations (elastic#78080) [Usage Collection] [schema] Explicit "array" definition (elastic#78141) Update tutorial-define-index.asciidoc (elastic#76973) Fix --no-basepath references in doc (elastic#78570) Move StubIndexPattern to data plugin and convert to TS. (elastic#78518) Index pattern class - remove unused methods (elastic#78538) [Security Solution] [ALL] Eliminates all console.error and console.warn from Jest output (elastic#78523) [Actions] avoids setting a default dedupKey on PagerDuty (elastic#77773) First stab at developer-focussed saved objects docs (elastic#71430) remove unnecessary config validations (elastic#78527)

elasticmachine · 2021-10-01T21:30:06Z

Pinging @elastic/kibana-core (Team:Core)

afharo added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:KibanaTelemetry v7.10.0 v8.0.0 labels Sep 22, 2020

[Usage Collection] [schema] Explicit "array" definition

39a8515

afharo force-pushed the usage_collection/schema/explicit_array_definition branch from 0327ccc to 39a8515 Compare September 22, 2020 12:34

afharo marked this pull request as ready for review September 22, 2020 14:52

afharo requested a review from a team as a code owner September 22, 2020 14:52

afharo requested a review from a team September 22, 2020 14:52

afharo requested review from a team as code owners September 22, 2020 14:52

jportner approved these changes Sep 22, 2020

View reviewed changes

botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 22, 2020

skh approved these changes Sep 23, 2020

View reviewed changes

oatkiller requested a review from michaelolo24 September 23, 2020 14:49

michaelolo24 approved these changes Sep 23, 2020

View reviewed changes

TinaHeiligers approved these changes Sep 23, 2020

View reviewed changes

afharo added the review label Sep 24, 2020

patrykkopycinski approved these changes Sep 24, 2020

View reviewed changes

Bamieh reviewed Sep 24, 2020

View reviewed changes

Merge branch 'master' into usage_collection/schema/explicit_array_def…

5a67615

…inition

afharo mentioned this pull request Sep 24, 2020

[Monitoring] Usage collection #75878

Merged

Merge branch 'master' into usage_collection/schema/explicit_array_def…

2044602

…inition

afharo requested a review from a team September 28, 2020 09:58

New monitoring collector with arrays

6c6e4b3

afharo force-pushed the usage_collection/schema/explicit_array_definition branch from fd9d9bf to 6c6e4b3 Compare September 28, 2020 10:24

shahzad31 approved these changes Sep 28, 2020

View reviewed changes

Merge branch 'master' into usage_collection/schema/explicit_array_def…

af5aa24

…inition

chrisronline approved these changes Sep 28, 2020

View reviewed changes

afharo merged commit db78d70 into elastic:master Sep 28, 2020

afharo deleted the usage_collection/schema/explicit_array_definition branch September 28, 2020 15:13

afharo mentioned this pull request Sep 28, 2020

[7.x] [Usage Collection] [schema] Explicit "array" definition (#78141) #78618

Merged

TinaHeiligers mentioned this pull request Sep 28, 2020

[Usage Collection] [schema] Support spreads + canvas definition #78481

Merged

1 task

lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021

lukeelmers removed the Team:KibanaTelemetry label Oct 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Usage Collection] [schema] Explicit "array" definition #78141

[Usage Collection] [schema] Explicit "array" definition #78141

afharo commented Sep 22, 2020

elasticmachine commented Sep 22, 2020

jportner left a comment •

edited

Loading

elasticmachine commented Sep 22, 2020

elasticmachine commented Sep 22, 2020

skh left a comment

michaelolo24 left a comment

TinaHeiligers left a comment

Bamieh Sep 24, 2020

afharo Sep 24, 2020

Bamieh Sep 24, 2020

afharo Sep 24, 2020 •

edited

Loading

afharo commented Sep 24, 2020

afharo commented Sep 28, 2020

shahzad31 left a comment

afharo commented Sep 28, 2020

kibanamachine commented Sep 28, 2020

chrisronline left a comment

elasticmachine commented Oct 1, 2021

[Usage Collection] [schema] Explicit "array" definition #78141

[Usage Collection] [schema] Explicit "array" definition #78141

Conversation

afharo commented Sep 22, 2020

Summary

Checklist

For maintainers

elasticmachine commented Sep 22, 2020

jportner left a comment • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Sep 22, 2020

elasticmachine commented Sep 22, 2020

skh left a comment

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

TinaHeiligers left a comment

Choose a reason for hiding this comment

Bamieh Sep 24, 2020

Choose a reason for hiding this comment

afharo Sep 24, 2020

Choose a reason for hiding this comment

Bamieh Sep 24, 2020

Choose a reason for hiding this comment

afharo Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

afharo commented Sep 24, 2020

afharo commented Sep 28, 2020

shahzad31 left a comment

Choose a reason for hiding this comment

afharo commented Sep 28, 2020

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

History

chrisronline left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 1, 2021

jportner left a comment •

edited

Loading

afharo Sep 24, 2020 •

edited

Loading