Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated discover with alt text #77660

Merged
merged 23 commits into from
Sep 28, 2020
Merged

updated discover with alt text #77660

merged 23 commits into from
Sep 28, 2020

Conversation

ncheckin
Copy link
Contributor

@ncheckin ncheckin commented Sep 16, 2020 •
edited by rayafratkina
Loading

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@KOTungseth KOTungseth added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.6.0 v7.7.0 v7.8.0 v7.9.0 labels Sep 16, 2020
@gchaps
Copy link
Contributor

gchaps commented Sep 21, 2020

jenkins test this

KOTungseth
KOTungseth approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! I've made a few edits for consistency, but otherwise, LGTM

docs/canvas/canvas-share-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-share-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-tutorial.asciidoc Outdated Show resolved Hide resolved
docs/discover/search.asciidoc Outdated Show resolved Hide resolved
docs/discover/set-time-filter.asciidoc Outdated Show resolved Hide resolved
docs/discover/viewing-field-stats.asciidoc Outdated Show resolved Hide resolved
docs/discover/field-filter.asciidoc Outdated Show resolved Hide resolved
docs/discover/document-data.asciidoc Outdated Show resolved Hide resolved
@KOTungseth
Copy link
Contributor

jenkins test this

@KOTungseth KOTungseth merged commit 37d49b0 into elastic:master Sep 28, 2020
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Sep 28, 2020
@ncheckin @KOTungseth
updated discover with alt text (elastic#77660)
ab51b09 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@KOTungseth KOTungseth mentioned this pull request Sep 28, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Sep 28, 2020
@ncheckin @KOTungseth
updated discover with alt text (elastic#77660)
b452d4c 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@KOTungseth KOTungseth mentioned this pull request Sep 28, 2020
Merged
KOTungseth pushed a commit to KOTungseth/kibana that referenced this pull request Sep 28, 2020
@ncheckin @KOTungseth
updated discover with alt text (elastic#77660)
d7b2052 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
# Conflicts:
#	docs/canvas/canvas-edit-workpads.asciidoc
#	docs/canvas/canvas-present-workpad.asciidoc
@KOTungseth KOTungseth mentioned this pull request Sep 28, 2020
Closed
KOTungseth pushed a commit to KOTungseth/kibana that referenced this pull request Sep 28, 2020
@ncheckin @KOTungseth
updated discover with alt text (elastic#77660)
7532cda 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
# Conflicts:
#	docs/canvas/canvas-edit-workpads.asciidoc
#	docs/canvas/canvas-present-workpad.asciidoc
#	docs/canvas/canvas-share-workpad.asciidoc
@KOTungseth KOTungseth mentioned this pull request Sep 28, 2020
Closed
KOTungseth pushed a commit to KOTungseth/kibana that referenced this pull request Sep 28, 2020
@ncheckin @KOTungseth
updated discover with alt text (elastic#77660)
7b177e5 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
# Conflicts:
#	docs/canvas/canvas-edit-workpads.asciidoc
#	docs/canvas/canvas-present-workpad.asciidoc
#	docs/canvas/canvas-share-workpad.asciidoc
#	docs/discover/search.asciidoc
#	docs/discover/set-time-filter.asciidoc
@KOTungseth KOTungseth mentioned this pull request Sep 28, 2020
Closed
KOTungseth added a commit that referenced this pull request Sep 28, 2020
@KOTungseth @ncheckin
updated discover with alt text (#77660) (#78639)
d0af9c7 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: ncheckin <68351161+ncheckin@users.noreply.github.com>
KOTungseth added a commit that referenced this pull request Sep 28, 2020
@KOTungseth @ncheckin
updated discover with alt text (#77660) (#78638)
2b6e571 
* Update context.asciidoc

* Update document-data.asciidoc

* Update field-filter.asciidoc

* Update search.asciidoc

* Update set-time-filter.asciidoc

* Update viewing-field-stats.asciidoc

* Update canvas-edit-workpads.asciidoc

* Update canvas-expression-lifecycle.asciidoc

* Update canvas-present-workpad.asciidoc

* Update canvas-share-workpad.asciidoc

* Update canvas-tutorial.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-share-workpad.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/canvas/canvas-tutorial.asciidoc

* Update docs/discover/search.asciidoc

* Update docs/discover/set-time-filter.asciidoc

* Update docs/discover/viewing-field-stats.asciidoc

* Update docs/discover/field-filter.asciidoc

* Update docs/discover/document-data.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: ncheckin <68351161+ncheckin@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 28, 2020
@gmmorris
Merge branch 'master' into task-manager/health
6b81d56 
* master:
  Fix APM lodash imports (elastic#78438)
  Add deprecated message to tile_map and region_map visualizations. (elastic#77683)
  Fix Lens smokescreen flaky tests (elastic#78566)
  updated discover with alt text (elastic#77660)
  Fix types (elastic#78619)
  Update tutorial-visualizing.asciidoc (elastic#76977)
  Update tutorial-discovering.asciidoc (elastic#76976)
  [Search] Error notification alignment (elastic#77788)
  Update tutorial-define-index.asciidoc (elastic#76975)
  [Lens] Fieldless operations (elastic#78080)
  [Usage Collection] [schema] Explicit "array" definition (elastic#78141)
  Update tutorial-define-index.asciidoc (elastic#76973)
  Fix --no-basepath references in doc (elastic#78570)
  Move StubIndexPattern to data plugin and convert to TS. (elastic#78518)
  Index pattern class - remove unused methods (elastic#78538)
  [Security Solution] [ALL] Eliminates all console.error and console.warn from Jest output (elastic#78523)
  [Actions] avoids setting a default dedupKey on PagerDuty (elastic#77773)
  First stab at developer-focussed saved objects docs (elastic#71430)
  remove unnecessary config validations (elastic#78527)
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOTungseth KOTungseth KOTungseth approved these changes

Assignees
No one assigned
Labels
💝community release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ncheckin @kibanamachine @elasticmachine @gchaps @KOTungseth @rayafratkina