Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Resolver] Fix functional test #77895

Merged
merged 2 commits into from
Sep 18, 2020
Merged

[Security Solution][Resolver] Fix functional test #77895

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a5d4de
update ftr selector
michaelolo24 Sep 18, 2020
a3f4c22
remove skip
michaelolo24 Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const queryBar = getService('queryBar');

// FLAKY: https://github.com/elastic/kibana/issues/77835
describe.skip('Endpoint Event Resolver', function () {
describe('Endpoint Event Resolver', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the // FLAKY comment if this is fixed now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this. @bkimmel do you mind adding this change in your PR? Don't want this to rerun the build...

before(async () => {
await esArchiver.load('endpoint/resolver_tree', { useCreate: true });
await pageObjects.hosts.navigateToSecurityHostsPage();
Expand Down Expand Up @@ -45,7 +45,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const nodeData: string[] = [];
const TableData: string[] = [];

const Table = await testSubjects.findAll('resolver:node-list:item');
const Table = await testSubjects.findAll('resolver:node-list:node-link:title');
for (const value of Table) {
const text = await value._webElement.getText();
TableData.push(text.split('\n')[0]);
Expand Down