Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Resolver] Fix functional test #77895

Merged
merged 2 commits into from
Sep 18, 2020
Merged

[Security Solution][Resolver] Fix functional test #77895

merged 2 commits into from
Sep 18, 2020

Conversation

michaelolo24
Copy link
Contributor

@michaelolo24 michaelolo24 commented Sep 18, 2020 •
edited
Loading

Summary

This PR is to fix: #77835

f64aa5b#diff-d39b1e72cac200eebf24f5410be28fd1R232-R246

@IgorGuz2000 it looks like the goal of this test is to compare the process button name in the graph to the name in the panel? I updated the selector in the test to use resolver:node-list:node-link:title which is the specific selector for the name in the panel:

kibana/x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx

Lines 243 to 245 in 613509d

<StyledLabelTitle data-test-subj="resolver:node-list:node-link:title">
{name}
</StyledLabelTitle>

For maintainers

@michaelolo24 michaelolo24 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 Feature:Functional Testing labels Sep 18, 2020
@michaelolo24 michaelolo24 requested review from a team as code owners September 18, 2020 13:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@oatkiller
Copy link
Contributor

@michaelolo24 I think you'll need to remove the .skip from the suite.

jonathan-buttner
jonathan-buttner reviewed Sep 18, 2020
View reviewed changes
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
@@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const queryBar = getService('queryBar');

// FLAKY: https://github.com/elastic/kibana/issues/77835
describe.skip('Endpoint Event Resolver', function () {
describe('Endpoint Event Resolver', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the // FLAKY comment if this is fixed now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this. @bkimmel do you mind adding this change in your PR? Don't want this to rerun the build...

@bkimmel bkimmel mentioned this pull request Sep 18, 2020
Merged
1 task
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@michaelolo24 michaelolo24 merged commit ef55756 into elastic:master Sep 18, 2020
@michaelolo24 michaelolo24 deleted the fix-functional-test branch September 18, 2020 15:40
michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Sep 18, 2020
@michaelolo24
[Security Solution][Resolver] Fix functional test (elastic#77895)
462140a 
# Conflicts:
#	x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
@michaelolo24 michaelolo24 mentioned this pull request Sep 18, 2020
Closed
michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Sep 21, 2020
@michaelolo24
[Security Solution][Resolver] Fix functional test (elastic#77895)
a10d904 
# Conflicts:
#	x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
@michaelolo24 michaelolo24 mentioned this pull request Sep 21, 2020
Closed
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 22, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77895 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77895 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77895 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77895 or prevent reminders by adding the backport:skip label.

@michaelolo24 michaelolo24 added the backport:skip This commit does not require backporting label Sep 29, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner left review comments

@bkimmel bkimmel bkimmel approved these changes

@IgorGuz2000 IgorGuz2000 Awaiting requested review from IgorGuz2000

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@michaelolo24 @elasticmachine @oatkiller @kibanamachine @bkimmel @jonathan-buttner