Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize: Bad request when working with histogram aggregation #77684

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

alexwizp
Copy link
Contributor

Closes: #77023

Summary

When changing the settings for the histogram aggregation, it's possible to run into a state no interval is provided

Steps to reproduce:

  1. Create "histogram" aggregation on X axis
  2. Set "Max bars" to 5
  3. Apply
  4. Remove "Max bars" value to get back to "Auto"
  5. Apply
  6. "Bad request" error is shown

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp added v7.10.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 16, 2020
@alexwizp alexwizp self-assigned this Sep 16, 2020
@alexwizp alexwizp added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:skip Skip the PR/issue when compiling release notes Feature:Vis Editor Visualization editor issues labels Sep 16, 2020
@lukeelmers
Copy link
Member

Code here makes sense, but we should also add unit and/or functional tests for this case.

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
data 1.5MB -142.0B 1.5MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review September 17, 2020 16:00
@alexwizp alexwizp requested a review from a team as a code owner September 17, 2020 16:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611 dej611 removed their request for review September 17, 2020 16:04
@dej611
Copy link
Contributor

dej611 commented Sep 17, 2020

Removed myself as reviewer as I contributed to the PR 😅

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM, thanks for adding that test!

Tested on chrome (macOS), and seems to be working as expected

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on safari

@alexwizp alexwizp merged commit 89ef12e into elastic:master Sep 18, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Sep 18, 2020
…ic#77684)

* Visualize: Bad request when working with histogram aggregation

Closes: elastic#77023

* ✏️ Add some more fix context

* ✅ Add test

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Sep 18, 2020
… (#77850)

* Visualize: Bad request when working with histogram aggregation

Closes: #77023

* ✏️ Add some more fix context

* ✅ Add test

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
* master: (92 commits)
  [ILM] Data tiers for 7.10 (elastic#76126)
  [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789)
  [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654)
  Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746)
  [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598)
  [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688)
  fixed react warning in Suspense in alert flyout (elastic#77777)
  [APM] Track usage of Gold+ features (elastic#77630)
  Visualize: Bad request when working with histogram aggregation (elastic#77684)
  remove legacy ES plugin (elastic#77703)
  [Lens] change name of custom query to filters (elastic#77725)
  skip flaky suite (elastic#76239)
  remove visual aspects of baseline job (elastic#77815)
  skip flaky suite (elastic#77835)
  Fixes typo in data recognizer text (elastic#77691)
  management/update trusted_apps jest snapshot
  [build] Use Elastic hosted UBI minimal base image (elastic#77776)
  [APM] Add transaction error rate alert (elastic#76933)
  [Security Solution] [Detections] Remove file validation on import route (elastic#77770)
  [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualize: Bad request when working with histogram aggregation
6 participants