[APM] Track usage of Gold+ features #77630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:skip
cauemarcondes
force-pushed
the
apm-gold-features
branch
from
5fe337f
to
6e49da5
Compare
sorenlouv
reviewed
Sep 17, 2020
x-pack/plugins/apm/server/feature.ts
Outdated
Comment on lines
61
to
62
| export const APM_SERVICE_MAPS_FEATURE_NAME = 'APM service maps'; | ||
| export const APM_SERVICE_MAPS_LICENSE_TYPE = 'platinum'; |
There was a problem hiding this comment.
nit: Since a feature name and a feature license belongs together I think we should group them like:
Suggested change
| export const APM_SERVICE_MAPS_FEATURE_NAME = 'APM service maps'; | |
| export const APM_SERVICE_MAPS_LICENSE_TYPE = 'platinum'; | |
| export const APM_SERVICE_MAPS_FEATURE = { | |
| name: 'APM service maps', | |
| license: 'platinum' | |
| } |
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Sep 17, 2020
sorenlouv
reviewed
Sep 17, 2020
cauemarcondes
commented
Sep 17, 2020
Comment on lines
+66
to
+105
| interface Feature { | ||
| name: string; | ||
| license: LicenseType; | ||
| } | ||
| type FeatureName = 'serviceMaps' | 'ml' | 'customLinks'; | ||
| export const features: Record<FeatureName, Feature> = { | ||
| serviceMaps: { | ||
| name: 'APM service maps', | ||
| license: 'platinum', | ||
| }, | ||
| ml: { | ||
| name: 'APM machine learning', | ||
| license: 'platinum', | ||
| }, | ||
| customLinks: { | ||
| name: 'APM custom links', | ||
| license: 'gold', | ||
| }, | ||
| }; | ||
|
|
||
| export function registerFeaturesUsage({ | ||
| licensingPlugin, | ||
| }: { | ||
| licensingPlugin: LicensingPluginSetup; | ||
| }) { | ||
| Object.values(features).forEach(({ name, license }) => { | ||
| licensingPlugin.featureUsage.register(name, license); | ||
| }); | ||
| } | ||
|
|
||
| export function notifyFeatureUsage({ | ||
| licensingPlugin, | ||
| featureName, | ||
| }: { | ||
| licensingPlugin: LicensingRequestHandlerContext; | ||
| featureName: FeatureName; | ||
| }) { | ||
| const feature = features[featureName]; | ||
| licensingPlugin.featureUsage.notifyUsage(feature.name); | ||
| } |
There was a problem hiding this comment.
@sqren what do you think of this? too much?
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Sep 17, 2020
|
Feel free to merge 👍 |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Sep 18, 2020
* adding license check * fixing api test * refactoring
cauemarcondes
added a commit
that referenced
this pull request
Sep 18, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (92 commits) [ILM] Data tiers for 7.10 (elastic#76126) [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789) [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654) Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746) [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598) [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688) fixed react warning in Suspense in alert flyout (elastic#77777) [APM] Track usage of Gold+ features (elastic#77630) Visualize: Bad request when working with histogram aggregation (elastic#77684) remove legacy ES plugin (elastic#77703) [Lens] change name of custom query to filters (elastic#77725) skip flaky suite (elastic#76239) remove visual aspects of baseline job (elastic#77815) skip flaky suite (elastic#77835) Fixes typo in data recognizer text (elastic#77691) management/update trusted_apps jest snapshot [build] Use Elastic hosted UBI minimal base image (elastic#77776) [APM] Add transaction error rate alert (elastic#76933) [Security Solution] [Detections] Remove file validation on import route (elastic#77770) [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #72054