[ML] Adding filebeat config to file dataviz #58152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
force-pushed
the
adding-filebeat-config-to-file-dataviz
branch
from
5cc40bc
to
acaf553
Compare
jgowdyelastic
requested review from
peteharverson,
droberts195,
darnautov,
walterra and
alvarezmelissa87
walterra
approved these changes
Feb 24, 2020
jgowdyelastic
added
:ml
Feature:File and Index Data Viz
|
Pinging @elastic/ml-ui (:ml) |
droberts195
reviewed
Feb 24, 2020
...c/application/datavisualizer/file_based/components/filebeat_config_flyout/filebeat_config.ts
Outdated
Show resolved
Hide resolved
jgowdyelastic
force-pushed
the
adding-filebeat-config-to-file-dataviz
branch
from
ddc423f
to
8ab3b4d
Compare
droberts195
reviewed
Feb 24, 2020
...c/application/datavisualizer/file_based/components/filebeat_config_flyout/filebeat_config.ts
Show resolved
Hide resolved
...c/application/datavisualizer/file_based/components/filebeat_config_flyout/filebeat_config.ts
Outdated
Show resolved
Hide resolved
...c/application/datavisualizer/file_based/components/filebeat_config_flyout/filebeat_config.ts
Outdated
Show resolved
Hide resolved
...c/application/datavisualizer/file_based/components/filebeat_config_flyout/filebeat_config.ts
Outdated
Show resolved
Hide resolved
droberts195
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
LGTM
I tested this with the latest changes and the config works now if you replace the placeholders.
Procedure:
- Download the latest Filebeat from https://www.elastic.co/downloads/beats/filebeat
- Copy the config proposed by the file uploader to the clipboard using the button provided
- Paste it into
filebeat.yml - Edit
filebeat.ymlto replace the placeholders with the actual file name/pattern, ES URL, ES username and password ./filebeat -c filebeat.yml -e
peteharverson
approved these changes
Feb 25, 2020
...c/application/datavisualizer/file_based/components/filebeat_config_flyout/filebeat_config.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 25, 2020
* [ML] Adding filebeat config to file dataviz * adding extra help text * removing commented out code * adding extra blank line to processors section * cleaning up types * moving hosts line out of function * typo in config text * updating config based on review * tiny refactor * translating paths text
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2020
…re/files-and-filetree * 'master' of github.com:elastic/kibana: (174 commits) [SIEM] Fix unnecessary re-renders on the Overview page (elastic#56587) Don't mutate error message (elastic#58452) Fix service map popover transaction duration (elastic#58422) [ML] Adding filebeat config to file dataviz (elastic#58152) [Uptime] Improve refresh handling when generating test data (elastic#58285) [Logs / Metrics UI] Remove path prefix from ViewSourceConfigur… (elastic#58238) [ML] Functional tests - adjust classification model memory (elastic#58445) [ML] Use event.timezone instead of beat.timezone in file upload (elastic#58447) [Logs UI] Unskip and stabilitize log column configuration tests (elastic#58392) [Telemetry] Separate the license retrieval from the stats in the usage collectors (elastic#57332) hide welcome screen for cloud (elastic#58371) Move src/legacy/ui/public/notify/app_redirect to kibana_legacy (elastic#58127) [ML] Functional tests - stabilize typing during df analytics creation (elastic#58227) fix short url in spaces (elastic#58313) [SIEM] Upgrades cypress to version 4.0.2 (elastic#58400) [Index management] Move to new platform "plugins" folder (elastic#58109) [kbn/optimizer] disable parallelization in terser plugin (elastic#58396) [Uptime] Delete useless try...catch blocks (elastic#58263) [Uptime] Use scripted metric for snapshot calculation (elastic#58247) (elastic#58389) [APM] Stabilize agent configuration API (elastic#57767) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
jgowdyelastic
added a commit
that referenced
this pull request
Feb 25, 2020
* [ML] Adding filebeat config to file dataviz * adding extra help text * removing commented out code * adding extra blank line to processors section * cleaning up types * moving hosts line out of function * typo in config text * updating config based on review * tiny refactor * translating paths text
elasticmachine
pushed a commit
to dhurley14/kibana
that referenced
this pull request
Feb 25, 2020
…58471) * [ML] Adding filebeat config to file dataviz * adding extra help text * removing commented out code * adding extra blank line to processors section * cleaning up types * moving hosts line out of function * typo in config text * updating config based on review * tiny refactor * translating paths text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to generate a Filebeat configuration for uploading additional data to the recently created index.
Fixes #56737
Also fixes an issue where lines which do not start with the expected line start regex are incorrectly added to the list of messages to import.
Affecting blank lines in csv or partial lines at the start of a rolled over log.
Checklist