[Index management] Move to new platform "plugins" folder #58109

sebelga · 2020-02-20T11:33:36Z

This PR moves the index_management app to the "plugins" new platform folder.

The changes are mainly files that have been moved and re-connect the 3 dependent apps:

Rollup
Cross cluster replication
ILM

Making sure both server (see the 3 extensions ilm, isRollupIndex, isFollowerIndex added to the index data):

And client extensions still work

@cuff-links It be awesome if you could run the test plan on the app! 👍

…ment

elasticmachine · 2020-02-20T11:34:45Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

sebelga · 2020-02-20T11:38:24Z

x-pack/legacy/plugins/index_management/index.ts

-import { plugin as initServerPlugin, Dependencies } from './server';
-
-export type ServerFacade = Legacy.Server;
-
 export function indexManagement(kibana: any) {


This file needs to stay until all dependent apps have migrated to the "plugins" folder.

alisonelizabeth

nice job @sebelga! another app to check off the migration list ✔️ 🎉

I left a couple questions in the code. I found a few issues with CCR and rollups when I disabled the index_management plugin that I think need to be addressed before merging. Also, it looks like there are some minor changes you made to the mappings editor (I did not comment on all of them) that seem unrelated to the migration. If that's the case, maybe it should be addressed in a separate PR?

Otherwise, code LGTM. I tested CCR, ILM and rollups integrations and everything worked as expected. I also went through all the actions for index and index templates.

Since I'll be out the next few days, maybe @jloleysens can take another look at this when you're ready?

alisonelizabeth · 2020-02-20T17:25:48Z

x-pack/legacy/plugins/rollup/server/plugin.ts

@@ -77,10 +77,10 @@ export class RollupsServerPlugin implements Plugin<void, void, any, any> {
    }

    if (
-      serverShim.plugins.index_management &&
-      serverShim.plugins.index_management.addIndexManagementDataEnricher
+      serverShim.plugins.indexManagement &&


nit: can indexManagement be moved out of the serverShim now?

Good call! 👍

alisonelizabeth · 2020-02-20T17:28:41Z

...public/application/components/mappings_editor/components/document_fields/document_fields.tsx

@@ -24,7 +24,7 @@ export const DocumentFields = React.memo(() => {
    if (editorType === 'json') {


are changes to this file related to the migration?

Yes, all the changes about adding/updating the array of dependencies of useCallback and useEffect were needed to fix a new rule in eslint (which is great as it helps us fix unnecessary re-renders).

alisonelizabeth · 2020-02-20T17:28:47Z

...s/mappings_editor/components/document_fields/field_parameters/analyzer_parameter_selects.tsx

@@ -56,15 +56,21 @@ export const AnalyzerParameterSelects = ({
    });


alisonelizabeth · 2020-02-20T17:46:10Z

.../application/components/mappings_editor/components/configuration_form/configuration_form.tsx

@@ -110,7 +110,7 @@ export const ConfigurationForm = React.memo(({ defaultValue }: Props) => {
      });


are changes to this file related to the migration?

alisonelizabeth · 2020-02-20T17:52:10Z

x-pack/plugins/index_management/server/plugin.ts

@@ -61,6 +67,9 @@ export class IndexMgmtServerPlugin implements Plugin<IndexMgmtSetup, void, any,
      indexDataEnricher: {
        add: this.indexDataEnricher.add.bind(this.indexDataEnricher),
      },
+      __legacy: {


is this needed?

A left over! I will remove it 👍

alisonelizabeth · 2020-02-20T17:56:45Z

x-pack/legacy/plugins/index_management/index.ts

-      server.expose('addIndexManagementDataEnricher', serverPublicApi.indexDataEnricher.add);
+    isEnabled(config: any) {
+      return (
+        config.get('xpack.index_management.enabled') && config.get('xpack.index_management.enabled')


should this just be return config.get('xpack.index_management.enabled')?

alisonelizabeth · 2020-02-20T18:00:02Z

x-pack/legacy/plugins/index_management/index.ts

+    config(Joi: any) {
+      return Joi.object({
+        // display menu item
+        ui: Joi.object({


Is this needed? I don't think xpack.index_management.ui.enabled is an existing setting.

Actually, I'm not quite sure I follow why the legacy config is needed, since it didn't exist previously. Can you explain?

I thought those were necessary but apparently not. I think that previously we forgot to add them though (at least the enabled config) 😊

I removed everything but configPrefix and id which seems to be the minimum for the dependent apps to not complain.

alisonelizabeth · 2020-02-20T18:06:41Z

x-pack/legacy/plugins/index_lifecycle_management/public/legacy.ts

@@ -20,7 +20,7 @@ import { addAllExtensions } from './np_ready/extend_index_management';
 if (chrome.getInjected('ilmUiEnabled')) {
  // We have to initialize this outside of the NP lifecycle, otherwise these extensions won't
  // be available in Index Management unless the user visits ILM first.
-  addAllExtensions();
+  addAllExtensions((npSetup.plugins as any).indexManagement.extensionsService);


I think this will cause issues if the index_management plugin is disabled.

Good catch, I added a check. I think this bug is present on master then.. but not for long 😊

alisonelizabeth · 2020-02-20T18:14:31Z

x-pack/legacy/plugins/cross_cluster_replication/public/extend_index_management/index.js

@@ -19,4 +19,4 @@ export const followerBadgeExtension = {
  filterExpression: 'isFollowerIndex:true',
 };

-extensionsService.addBadge(followerBadgeExtension);
+npSetup.plugins.indexManagement.extensionsService.addBadge(followerBadgeExtension);


I think this is going to cause issues if index management is disabled.

Good catch, I added a check.

…x-management-plugins-folder

sebelga · 2020-02-21T07:19:18Z

Thanks for the review @alisonelizabeth !

I found a few issues with CCR and rollups when I disabled the index_management plugin that I think need to be addressed before merging.

Great catch, I fixed them. I think those are already present on master as I did not touch the logic and simply updated the pointer to the extensions.

it looks like there are some minor changes you made to the mappings editor (I did not comment on all of them) that seem unrelated to the migration. If that's the case, maybe it should be addressed in a separate PR?

All the changes were required to pass eslint which now has a rule that enforces that the correct elements are declared in the dependencies array.

jloleysens

Code changes look good, could not spot a regression during local testing.

sebelga · 2020-02-24T06:07:44Z

@elasticmachine merge upstream

snide

Not a requirement, but you might want to consider changing the way your Sass imports into these files now that the optimizer is improved. https://github.com/elastic/kibana/tree/master/packages/kbn-optimizer

Each sass file can now be imported directly into the JS component, rather than bundled into a giant index at the app root.
If you do this, it would make sense to remove the _ prefix on the sass files you choose to import directly. The underscore denotes a partial that is imported into another file that gets compiled.

The benefits to do this (not just in this plugin, but all through Kibana) is that you only load the CSS you need.

sebelga · 2020-02-24T11:59:09Z

Thanks for the review @snide ! I will keep it as a note but I prefer to keep this PR focused on moving to the "plugins" folder and have a separate PR for this enhancement. It looks like a powerful feature indeed!

sebelga · 2020-02-24T11:59:26Z

@elasticmachine merge upstream

sebelga · 2020-02-25T04:59:42Z

@elasticmachine merge upstream

kibanamachine · 2020-02-25T06:54:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4443ae1

History

💔 Build #28410 failed 108ff98
💔 Build #28361 failed 43233d8
💚 Build #28097 succeeded e6bb10a
💔 Build #28073 failed acca91e
💔 Build #27871 failed 2330607

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…re/files-and-filetree * 'master' of github.com:elastic/kibana: (174 commits) [SIEM] Fix unnecessary re-renders on the Overview page (elastic#56587) Don't mutate error message (elastic#58452) Fix service map popover transaction duration (elastic#58422) [ML] Adding filebeat config to file dataviz (elastic#58152) [Uptime] Improve refresh handling when generating test data (elastic#58285) [Logs / Metrics UI] Remove path prefix from ViewSourceConfigur… (elastic#58238) [ML] Functional tests - adjust classification model memory (elastic#58445) [ML] Use event.timezone instead of beat.timezone in file upload (elastic#58447) [Logs UI] Unskip and stabilitize log column configuration tests (elastic#58392) [Telemetry] Separate the license retrieval from the stats in the usage collectors (elastic#57332) hide welcome screen for cloud (elastic#58371) Move src/legacy/ui/public/notify/app_redirect to kibana_legacy (elastic#58127) [ML] Functional tests - stabilize typing during df analytics creation (elastic#58227) fix short url in spaces (elastic#58313) [SIEM] Upgrades cypress to version 4.0.2 (elastic#58400) [Index management] Move to new platform "plugins" folder (elastic#58109) [kbn/optimizer] disable parallelization in terser plugin (elastic#58396) [Uptime] Delete useless try...catch blocks (elastic#58263) [Uptime] Use scripted metric for snapshot calculation (elastic#58247) (elastic#58389) [APM] Stabilize agent configuration API (elastic#57767) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx

# Conflicts: # x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_state.tsx

kibanamachine · 2020-02-26T07:48:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

… (#58458)

sebelga added 13 commits February 20, 2020 15:41

Move index_management to "plugins" folder

4984cbf

Remove index.html from "public" folder

73568a7

Import "extensionsService" in legacy from ngSetup.plugins.indexManage…

42abf51

…ment

Fix indexDataEnricher extend from legacy plugins

3034bcc

Update public contract

a64cc92

Update plugin path in i18nrc

7bcef05

Export config schema from server

52b8bcc

Add Legacy type to config object in remote_clusters app

a26999f

Expose config$ from __legacy in setup()

517f639

Expose index_management config for legacy apps

383cf0e

Fix infinite re-render from useEffect()

dfd7d4d

Use "brace" instead of "ace" to edit index settings

0be4ad1

Fix indexManagement plugin link for server extension

5e33714

sebelga requested a review from a team as a code owner February 20, 2020 11:33

sebelga requested review from alisonelizabeth and cuff-links February 20, 2020 11:34

sebelga added Feature:Index Management Index and index templates UI Feature:NP Migration Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 v8.0.0 labels Feb 20, 2020

sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Feb 20, 2020

sebelga commented Feb 20, 2020

View reviewed changes

Fix TS issues

2330607

alisonelizabeth reviewed Feb 20, 2020

View reviewed changes

sebelga added 4 commits February 21, 2020 10:56

Remove indexManagement from rollup server shim

32b4724

Remove config$ export as legacy from setup

56f3338

Check first if indexManagement is enabled before calling extensions

f5cd28b

Remove unnecessary legacy config

40fcf7e

Merge remote-tracking branch 'upstream/master' into np-migration/inde…

acca91e

…x-management-plugins-folder

sebelga requested a review from jloleysens February 21, 2020 07:13

Fix jest test

e6bb10a

jloleysens approved these changes Feb 21, 2020

View reviewed changes

Merge branch 'master' into np-migration/index-management-plugins-folder

43233d8

snide reviewed Feb 24, 2020

View reviewed changes

Merge branch 'master' into np-migration/index-management-plugins-folder

108ff98

snide approved these changes Feb 24, 2020

View reviewed changes

Merge branch 'master' into np-migration/index-management-plugins-folder

4443ae1

sebelga merged commit 277b380 into elastic:master Feb 25, 2020

sebelga deleted the np-migration/index-management-plugins-folder branch February 25, 2020 07:42

sebelga mentioned this pull request Feb 25, 2020

[7.x] [Index management] Move to new platform "plugins" folder (#58109) #58458

Merged

sebelga added a commit to sebelga/kibana that referenced this pull request Feb 26, 2020

[Index management] Move to new platform "plugins" folder (elastic#58109)

5507a72

# Conflicts: # x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_state.tsx

kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 26, 2020

sebelga added a commit that referenced this pull request Feb 26, 2020

[7.x] [Index management] Move to new platform "plugins" folder (#58109)…

3333c09

… (#58458)

cjcenizal mentioned this pull request Mar 5, 2020

[Index management] Client-side NP ready #57186

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Index management] Move to new platform "plugins" folder #58109

[Index management] Move to new platform "plugins" folder #58109

sebelga commented Feb 20, 2020 •

edited

Loading

elasticmachine commented Feb 20, 2020

sebelga Feb 20, 2020

alisonelizabeth left a comment

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020

alisonelizabeth Feb 20, 2020

alisonelizabeth Feb 20, 2020

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020

alisonelizabeth Feb 20, 2020

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020 •

edited

Loading

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020

alisonelizabeth Feb 20, 2020

sebelga Feb 21, 2020

sebelga commented Feb 21, 2020

jloleysens left a comment

sebelga commented Feb 24, 2020

snide left a comment •

edited

Loading

sebelga commented Feb 24, 2020

sebelga commented Feb 24, 2020

sebelga commented Feb 25, 2020

kibanamachine commented Feb 25, 2020

kibanamachine commented Feb 26, 2020

		@@ -24,7 +24,7 @@ export const DocumentFields = React.memo(() => {
		if (editorType === 'json') {

		@@ -56,15 +56,21 @@ export const AnalyzerParameterSelects = ({
		});

		@@ -110,7 +110,7 @@ export const ConfigurationForm = React.memo(({ defaultValue }: Props) => {
		});

[Index management] Move to new platform "plugins" folder #58109

[Index management] Move to new platform "plugins" folder #58109

Conversation

sebelga commented Feb 20, 2020 • edited Loading

elasticmachine commented Feb 20, 2020

Choose a reason for hiding this comment

alisonelizabeth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebelga Feb 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebelga commented Feb 21, 2020

jloleysens left a comment

Choose a reason for hiding this comment

sebelga commented Feb 24, 2020

snide left a comment • edited Loading

Choose a reason for hiding this comment

sebelga commented Feb 24, 2020

sebelga commented Feb 24, 2020

sebelga commented Feb 25, 2020

kibanamachine commented Feb 25, 2020

💚 Build Succeeded

History

kibanamachine commented Feb 26, 2020

sebelga commented Feb 20, 2020 •

edited

Loading

sebelga Feb 21, 2020 •

edited

Loading

snide left a comment •

edited

Loading