[Monitoring] Refactor index patterns from configurable to constants #29528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:breaking
v7.0.0
Team:Monitoring
|
Pinging @elastic/stack-monitoring |
💔 Build Failed |
💚 Build Succeeded |
ycombinator
reviewed
Jan 29, 2019
ycombinator
reviewed
Jan 29, 2019
x-pack/plugins/xpack_main/server/lib/telemetry/monitoring/get_high_level_stats.js
Show resolved
Hide resolved
ycombinator
approved these changes
Jan 29, 2019
💚 Build Succeeded |
|
@chrisronline Can you please update the breaking changes doc and include this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28958
Per the issue, we don't really want to expose monitoring index patterns as configurable, even though we technically do (but don't document it). We have a chance in 7.0 to make a technical breaking change by removing this ability so here we go!
"Release Note: Historically, configuring monitoring index patterns was possible, but undocumented. Moving forward, it will be detrimental to any users changing these from their defaults so the ability to configure these is no longer available. All configuration for
xpack.monitoring.*.index_patternare now ignored."