[Monitoring] Add breaking change for constants change #30710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/stack-monitoring |
ycombinator
reviewed
Feb 11, 2019
docs/migration/migrate_7_0.asciidoc
Outdated
| @@ -119,6 +119,10 @@ Previously set `xpack.monitoring.elasticsearch.ssl.verify` is equal to `xpack.mo | |||
|
|
|||
| *Impact:* Users with `xpack.monitoring.report_stats` set should use `xpack.xpack_main.telemetry.enabled` instead. | |||
|
|
|||
| [float] | |||
| === kibana.yml setting `xpack.monitoring.*.index_pattern` is no longer valid | |||
There was a problem hiding this comment.
Can you pluralize settings in this section or create separate sections for each individual setting. Singular "setting" with the wildcard doesn't read well (to me anyway) but I'll defer to @gchaps or another tech writer for their opinion.
|
FYI, I just created a PR that adds a "Settings changes" section in the Kibana breaking changes. I recommend waiting until #30757 is merged and following that style with this change too. |
cachedout
requested changes
Feb 12, 2019
|
Sorry for all the commits! I merged the changes from #30757 then edited these new breaking changes to fit in. |
|
Pinging @elastic/kibana-docs |
lcawl
approved these changes
Feb 12, 2019
💚 Build Succeeded |
cachedout
approved these changes
Feb 12, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 12, 2019
* Add breaking change for constants change * PR feedback * [DOCS] Edits the new breaking changes * [DOCS] Reverts merge * Removes yarn.lock from PR * Removes accidental files from PR * [DOCS] Adds settings section to Breaking changes (elastic#30757) * [DOCS] Edits the new breaking changes
chrisronline
added a commit
that referenced
this pull request
Feb 13, 2019
* Add breaking change for constants change * PR feedback * [DOCS] Edits the new breaking changes * [DOCS] Reverts merge * Removes yarn.lock from PR * Removes accidental files from PR * [DOCS] Adds settings section to Breaking changes (#30757) * [DOCS] Edits the new breaking changes
|
Backport: 7.0: 02a7ff8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds breaking change description for changes in #29528