-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Add breaking change for constants change #30710
[Monitoring] Add breaking change for constants change #30710
Conversation
Pinging @elastic/stack-monitoring |
docs/migration/migrate_7_0.asciidoc
Outdated
@@ -119,6 +119,10 @@ Previously set `xpack.monitoring.elasticsearch.ssl.verify` is equal to `xpack.mo | |||
|
|||
*Impact:* Users with `xpack.monitoring.report_stats` set should use `xpack.xpack_main.telemetry.enabled` instead. | |||
|
|||
[float] | |||
=== kibana.yml setting `xpack.monitoring.*.index_pattern` is no longer valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pluralize settings in this section or create separate sections for each individual setting. Singular "setting" with the wildcard doesn't read well (to me anyway) but I'll defer to @gchaps or another tech writer for their opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I just created a PR that adds a "Settings changes" section in the Kibana breaking changes. I recommend waiting until #30757 is merged and following that style with this change too. |
Sorry for all the commits! I merged the changes from #30757 then edited these new breaking changes to fit in. |
Pinging @elastic/kibana-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and builds successfully
💚 Build Succeeded |
* Add breaking change for constants change * PR feedback * [DOCS] Edits the new breaking changes * [DOCS] Reverts merge * Removes yarn.lock from PR * Removes accidental files from PR * [DOCS] Adds settings section to Breaking changes (elastic#30757) * [DOCS] Edits the new breaking changes
* Add breaking change for constants change * PR feedback * [DOCS] Edits the new breaking changes * [DOCS] Reverts merge * Removes yarn.lock from PR * Removes accidental files from PR * [DOCS] Adds settings section to Breaking changes (#30757) * [DOCS] Edits the new breaking changes
Backport: 7.0: 02a7ff8 |
Adds breaking change description for changes in #29528