Move monitoring index patterns to constants

[ycombinator]

Currently a user could change the index patterns used for Stack Monitoring indices via kibana.yml settings:

kibana/x-pack/plugins/monitoring/config.js

Line 33 in efb876d

index_pattern: Joi.string().default('.monitoring-*-6-*'),

kibana/x-pack/plugins/monitoring/config.js

Line 35 in efb876d

index_pattern: Joi.string().default('.monitoring-kibana-6-*'),

kibana/x-pack/plugins/monitoring/config.js

Line 42 in efb876d

index_pattern: Joi.string().default('.monitoring-logstash-6-*')

kibana/x-pack/plugins/monitoring/config.js

Line 45 in efb876d

index_pattern: Joi.string().default('.monitoring-beats-6-*')

kibana/x-pack/plugins/monitoring/config.js

Line 65 in efb876d

index_pattern: Joi.string().default('.monitoring-es-6-*'),

The naming of these index patterns is an implementation detail and we shouldn't allow users to be able to change them. In fact, these settings are currently undocumented, precisely because we don't want users changing them.

We should make this contract more explicit by moving these settings to constants, making it ergonomic for developers while at the same time not prone to unintentional misuse by users.

[elasticmachine]

Pinging @elastic/stack-monitoring

[cachedout]

Nice catch!