Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15] [Inference] Fix table responsiveness (#189265) #189486

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[8.15] [Inference] Fix table responsiveness (#189265) #189486

merged 1 commit into from
Jul 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

@sphilipse
[Inference] Fix table responsiveness (elastic#189265)
d111b63 
## Summary

This improves the inference endpoint's table responsiveness and code
clarity. It also fixes a bug where deleting one endpoint and then a
second one would try to delete the same endpoint twice.
<img width="879" alt="Screenshot 2024-07-26 at 12 18 59"
src="https://github.com/user-attachments/assets/003f47ef-6cd4-4244-abe4-141ebf570a98">
<img width="1016" alt="Screenshot 2024-07-26 at 12 18 52"
src="https://github.com/user-attachments/assets/9d7fd119-6c5c-4d5d-b381-68f6189e56e5">
<img width="1410" alt="Screenshot 2024-07-26 at 12 18 37"
src="https://github.com/user-attachments/assets/790fe616-36d4-4a11-9ced-dca325efb753">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a9ae3e5)
@kibanamachine kibanamachine enabled auto-merge (squash) July 30, 2024 10:21
@kibanamachine kibanamachine mentioned this pull request Jul 30, 2024
Merged
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchInferenceEndpoints 103 95 -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchInferenceEndpoints 67.5KB 64.5KB -3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchInferenceEndpoints 5.3KB 5.4KB +56.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sphilipse

@kibanamachine kibanamachine merged commit d499ba5 into elastic:8.15 Jul 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions approved these changes

Assignees

@sphilipse sphilipse

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @sphilipse