[Inference] Fix table responsiveness #189265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
joemcelroy
approved these changes
Jul 26, 2024
|
Tested locally. The change looks good to me. |
saikatsarkar056
approved these changes
Jul 26, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 30, 2024
## Summary This improves the inference endpoint's table responsiveness and code clarity. It also fixes a bug where deleting one endpoint and then a second one would try to delete the same endpoint twice. <img width="879" alt="Screenshot 2024-07-26 at 12 18 59" src="https://github.com/user-attachments/assets/003f47ef-6cd4-4244-abe4-141ebf570a98"> <img width="1016" alt="Screenshot 2024-07-26 at 12 18 52" src="https://github.com/user-attachments/assets/9d7fd119-6c5c-4d5d-b381-68f6189e56e5"> <img width="1410" alt="Screenshot 2024-07-26 at 12 18 37" src="https://github.com/user-attachments/assets/790fe616-36d4-4a11-9ced-dca325efb753"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a9ae3e5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 30, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[Inference] Fix table responsiveness (#189265)](#189265) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-30T10:16:33Z","message":"[Inference] Fix table responsiveness (#189265)\n\n## Summary\r\n\r\nThis improves the inference endpoint's table responsiveness and code\r\nclarity. It also fixes a bug where deleting one endpoint and then a\r\nsecond one would try to delete the same endpoint twice.\r\n<img width=\"879\" alt=\"Screenshot 2024-07-26 at 12 18 59\"\r\nsrc=\"https://github.com/user-attachments/assets/003f47ef-6cd4-4244-abe4-141ebf570a98\">\r\n<img width=\"1016\" alt=\"Screenshot 2024-07-26 at 12 18 52\"\r\nsrc=\"https://github.com/user-attachments/assets/9d7fd119-6c5c-4d5d-b381-68f6189e56e5\">\r\n<img width=\"1410\" alt=\"Screenshot 2024-07-26 at 12 18 37\"\r\nsrc=\"https://github.com/user-attachments/assets/790fe616-36d4-4a11-9ced-dca325efb753\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a9ae3e53f12576b6a360fcb714e94c89eaf3751b","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Search","v8.15.0","v8.16.0"],"title":"[Inference] Fix table responsiveness","number":189265,"url":"#189265 Fix table responsiveness (#189265)\n\n## Summary\r\n\r\nThis improves the inference endpoint's table responsiveness and code\r\nclarity. It also fixes a bug where deleting one endpoint and then a\r\nsecond one would try to delete the same endpoint twice.\r\n<img width=\"879\" alt=\"Screenshot 2024-07-26 at 12 18 59\"\r\nsrc=\"https://github.com/user-attachments/assets/003f47ef-6cd4-4244-abe4-141ebf570a98\">\r\n<img width=\"1016\" alt=\"Screenshot 2024-07-26 at 12 18 52\"\r\nsrc=\"https://github.com/user-attachments/assets/9d7fd119-6c5c-4d5d-b381-68f6189e56e5\">\r\n<img width=\"1410\" alt=\"Screenshot 2024-07-26 at 12 18 37\"\r\nsrc=\"https://github.com/user-attachments/assets/790fe616-36d4-4a11-9ced-dca325efb753\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a9ae3e53f12576b6a360fcb714e94c89eaf3751b"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"#189265 Fix table responsiveness (#189265)\n\n## Summary\r\n\r\nThis improves the inference endpoint's table responsiveness and code\r\nclarity. It also fixes a bug where deleting one endpoint and then a\r\nsecond one would try to delete the same endpoint twice.\r\n<img width=\"879\" alt=\"Screenshot 2024-07-26 at 12 18 59\"\r\nsrc=\"https://github.com/user-attachments/assets/003f47ef-6cd4-4244-abe4-141ebf570a98\">\r\n<img width=\"1016\" alt=\"Screenshot 2024-07-26 at 12 18 52\"\r\nsrc=\"https://github.com/user-attachments/assets/9d7fd119-6c5c-4d5d-b381-68f6189e56e5\">\r\n<img width=\"1410\" alt=\"Screenshot 2024-07-26 at 12 18 37\"\r\nsrc=\"https://github.com/user-attachments/assets/790fe616-36d4-4a11-9ced-dca325efb753\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a9ae3e53f12576b6a360fcb714e94c89eaf3751b"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves https://github.com/elastic/search-team/issues/7979
Summary
This improves the inference endpoint's table responsiveness and code clarity. It also fixes a bug where deleting one endpoint and then a second one would try to delete the same endpoint twice.
