[SLO Form] Use saved Data view id , handle runtime mappings

[shahzad31]

Summary

Fixes #173771

Use saved data view id instead of index pattern where it's available.
Inject runtime mappings from the dataview into transform.

• Go to Discover and add a runtime field to the data view (this is only available in Discover)
• Make sure filtering works based on the data view

We are not supporting "scripted fields" from the Index Management DataView editor.

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kdelemme]

Overall that's a good idea that we had also with Chris a while back.

But I'm a bit concerned with including all runtime fields every time they exists when we create a transform with a DataView. I think we can do two things to reduce the risk on performance:

1. Add the runtime fields when the user specifically asks for it
2. Add only the runtime fields that are necessary for the different queries

The second option is obviously harder and more cumbersome in terms of surface API that need to changed, but would not require the first option at all.
The first option gives us at least a safety switch, and moves any performance issue into the customer hands, and is very easy to implement.

So if we move forward with this, I'd request for at least the settings option to be included as well (slo.settings can be used).

What do you think?

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[shahzad31]

@kdelemme i have addressed the rest of the comments, let me know if we need further discussion regarding run time mappings

[shahzad31]

@elasticmachine merge upstream

I won't have time to test it locally, but code change LGTM. Chris to take over

[shahzad31]

added a callout

[simianhacker]

It looks like the only indicator that works with a "scripted field" is KQL. They are not showing up in the filters for any of the other indicators. I was also expecting to be able to use them as a field for a "Timeslice Metric" and "Custom Metric" which it doesn't seem to appear in the field drop down.

For reference, I created a scripted field on the "Message Processor" data view from fake_stack called processor.failed with the source doc['processor.accepted'].value - doc['processor.processed'].value. I doubled checked that this field is aggregatable in Lens.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 32ffc79
• Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-176662-32ffc7968a33
• Observability Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
slo	847	850	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
slo	64	65	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
slo	858.2KB	860.4KB	+2.2KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
module count	-	5499	+5499
total size	-	8.9MB	+8.9MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
observability	122.7KB	122.8KB	+147.0B

Unknown metric groups

API count

id	before	after	diff
slo	64	65	+1

History

• 💚 Build #214352 succeeded 1f60922
• 💔 Build #214245 failed 68a1f52
• 💔 Build #214177 failed 44c35db
• 💔 Build #210672 failed 85186d4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kdelemme]

merge with above useKibana()

[kdelemme]

Users will need to harden their runtime mappings when used in an SLO otherwise the transform won't start:

For example:

if (doc["http.request.bytes"].size()==0) {
    emit(false);
    return;
} 

emit(doc["http.request.bytes"].value < 600)