Skip to content

Commit

Permalink
update test
Browse files Browse the repository at this point in the history
  • Loading branch information
@shahzad31
shahzad31 committed Jun 5, 2024
1 parent a53dcfc commit 44c35db
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 15 deletions.
4 changes: 2 additions & 2 deletions ...bility_solution/slo/server/services/transform_generators/apm_transaction_duration.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('APM Transaction Duration Transform Generator', () => {
expect(transform.pivot?.group_by).toMatchSnapshot();
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLO({
indicator: createAPMTransactionDurationIndicator(),
settings: {
Expand All @@ -163,7 +163,7 @@ describe('APM Transaction Duration Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, spaceId, dataViewsService);
const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down
4 changes: 2 additions & 2 deletions ...lity_solution/slo/server/services/transform_generators/apm_transaction_error_rate.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ describe('APM Transaction Error Rate Transform Generator', () => {
expect(transform.pivot?.group_by).toMatchSnapshot();
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLO({
indicator: createAPMTransactionErrorRateIndicator(),
settings: {
Expand All @@ -166,7 +166,7 @@ describe('APM Transaction Error Rate Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, spaceId, dataViewsService);
const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down
8 changes: 5 additions & 3 deletions ...plugins/observability_solution/slo/server/services/transform_generators/histogram.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ describe('Histogram Transform Generator', () => {
},
}),
});

expect(generator.getTransformParams(anSLO, spaceId, dataViewsService)).rejects.toThrow(
/Invalid KQL: foo:/
);
});

it('throws when the total filter is invalid', () => {
it('throws when the total filter is invalid', async () => {
const anSLO = createSLO({
indicator: createHistogramIndicator({
good: {
Expand All @@ -46,6 +47,7 @@ describe('Histogram Transform Generator', () => {
},
}),
});

expect(generator.getTransformParams(anSLO, spaceId, dataViewsService)).rejects.toThrow(
/Invalid KQL: foo:/
);
Expand Down Expand Up @@ -174,7 +176,7 @@ describe('Histogram Transform Generator', () => {
expect(transform.pivot!.aggregations!['slo.denominator']).toMatchSnapshot();
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLO({
indicator: createHistogramIndicator(),
settings: {
Expand All @@ -184,7 +186,7 @@ describe('Histogram Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, spaceId, dataViewsService);
const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down
4 changes: 2 additions & 2 deletions ...lugins/observability_solution/slo/server/services/transform_generators/kql_custom.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ describe('KQL Custom Transform Generator', () => {
expect(transform.pivot!.aggregations!['slo.denominator']).toMatchSnapshot();
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLO({
indicator: createKQLCustomIndicator(),
settings: {
Expand All @@ -140,7 +140,7 @@ describe('KQL Custom Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, spaceId, dataViewsService);
const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down
4 changes: 2 additions & 2 deletions ...ins/observability_solution/slo/server/services/transform_generators/metric_custom.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ describe('Metric Custom Transform Generator', () => {
expect(transform.pivot!.aggregations!['slo.denominator']).toMatchSnapshot();
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLO({
indicator: createMetricCustomIndicator(),
settings: {
Expand All @@ -239,7 +239,7 @@ describe('Metric Custom Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, spaceId, dataViewsService);
const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down
4 changes: 2 additions & 2 deletions ...ability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ describe('Synthetics Availability Transform Generator', () => {
});
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLO({
indicator: createSyntheticsAvailabilityIndicator(),
settings: {
Expand All @@ -417,7 +417,7 @@ describe('Synthetics Availability Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, 'default', dataViewsService);
const transform = await generator.getTransformParams(slo, 'default', dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down
4 changes: 2 additions & 2 deletions .../observability_solution/slo/server/services/transform_generators/timeslice_metric.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ describe('Timeslice Metric Transform Generator', () => {
});
});

it("overrides the range filter when 'preventInitialBackfill' is true", () => {
it("overrides the range filter when 'preventInitialBackfill' is true", async () => {
const slo = createSLOWithTimeslicesBudgetingMethod({
indicator: everythingIndicator,
settings: {
Expand All @@ -185,7 +185,7 @@ describe('Timeslice Metric Transform Generator', () => {
},
});

const transform = generator.getTransformParams(slo, spaceId, dataViewsService);
const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);

// @ts-ignore
const rangeFilter = transform.source.query.bool.filter.find((f) => 'range' in f);
Expand Down

0 comments on commit 44c35db

Please sign in to comment.