Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Support scripted/runtime fields for DataViews #173771

Closed
simianhacker opened this issue Dec 20, 2023 · 2 comments · Fixed by #176662
Closed

[SLO] Support scripted/runtime fields for DataViews #173771

simianhacker opened this issue Dec 20, 2023 · 2 comments · Fixed by #176662
Assignees
@shahzad31
Labels
enhancement New value added to drive a business result Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@simianhacker
Copy link
Member

🍒 Summary

It's common for people to use scripted/runtime fields to create ad hoc fields which don't exists in the source index pattern of the DataView. Currently, our implementation of DataViews is only a convenient way to re-use an index pattern. To fully support DataViews we are going to need to support scripted/runtime fields so that users can start in Lens or Discover (where DataViews features are mostly developed) and move to an SLO.

❓ Questions to Answer

  • Should we allow adhoc scripted fields similar to Lens and Discover?
  • How do we let the user know that if they change the DataView / Scripted fields they need to re-save the SLO to get the updates?
  • Do we just pull the scripted fields from the DataView or do we need to store these in the SLO definition?

🎯 Acceptance Criteria

  • Support scripted/runtime fields in the indicator preview chart
  • Support scripted/runtime fields in the KQL bars on ALL indicators
  • When creating the SLI transform, we need to inject the scripted/runtime fields
@simianhacker simianhacker added enhancement New value added to drive a business result Feature:SLO labels Dec 20, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 20, 2023
@nickpeihl nickpeihl added the Team:obs-ux-management Observability Management User Experience Team label Dec 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 27, 2023
@simianhacker
Copy link
Member Author

We should probably do a POC to play around with scripted/runtime fields and what the limitations.

@shahzad31 shahzad31 mentioned this issue Feb 6, 2024
Closed
@shahzad31 shahzad31 self-assigned this Feb 21, 2024
@shahzad31 shahzad31 mentioned this issue Feb 21, 2024
Merged
2 tasks
shahzad31 added a commit that referenced this issue Jun 7, 2024
@shahzad31 @kibanamachine
[SLO Form] Use saved Data view id , handle runtime mappings (#176662)
f3fdb0f 
## Summary

Fixes #173771


Use saved data view id instead of index pattern where it's available.
Inject runtime mappings from the dataview into transform.

- [ ] Go to Discover and add a runtime field to the data view (this is
only available in Discover)
- [ ] Make sure filtering works based on the data view

We are not supporting "scripted fields" from the Index Management
DataView editor.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
enhancement New value added to drive a business result Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SLO Form] Use saved Data view id , handle runtime mappings shahzad31/kibana
4 participants
@simianhacker @nickpeihl @shahzad31 @elasticmachine