-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Extract hook for agentList table logic #175528
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @criamico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Love seeing hooks tested in isolation, as we didn't have much (if any) unit test style coverage of this logic before.
I think maybe a future pass at this would be to break the one gigantic hook down into smaller ones. Having a "god hook" like this has its tradeoffs (see the gigantic number of values returned by the hook), but this is an excellent improvement that helps us add test coverage to a key UI component in Fleet 🚀
That would be great, but I didn't want to go too deep in the rabbit hole. We can then iterate on this one and maybe try to simplify some of the calls we do on that page. |
Closes elastic#131153 Follow up of elastic#175318 ## Summary Extract the main logic for agentList component in a separate hook. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes elastic#131153 Follow up of elastic#175318 ## Summary Extract the main logic for agentList component in a separate hook. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes elastic#131153 Follow up of elastic#175318 ## Summary Extract the main logic for agentList component in a separate hook. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes #131153
Follow up of #175318
Summary
Extract the main logic for agentList component in a separate hook.
Checklist