Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Refactor AgentListPage component #131153

Closed
criamico opened this issue Apr 28, 2022 · 2 comments · Fixed by #175528
Closed

[Fleet] Refactor AgentListPage component #131153

criamico opened this issue Apr 28, 2022 · 2 comments · Fixed by #175528
Labels
refactoring Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@criamico
Copy link
Contributor

At the time of writing the AgentListPage component is ~700 lines of code.

It would be good to refactor this component and break it to smaller ones to make it more readable and maintainable.
@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang added refactoring technical debt Improvement of the software architecture and operational architecture labels Apr 28, 2022
@criamico
Copy link
Contributor Author

criamico commented Mar 9, 2023

I'm doing some refactor and break up of the component in #152555, mostly extracting the kueryBuilder functionality and part of the smaller components.

It would be good to try extracting some of the state and moving it to the child components, in fact when I tried putting additional state on the component it was not handling it correctly.

@criamico criamico mentioned this issue Jan 25, 2024
Merged
2 tasks
criamico added a commit that referenced this issue Jan 29, 2024
@criamico @kibanamachine
[Fleet] Extract hook for agentList table logic (#175528)
c6e1a25 
Closes #131153
Follow up of #175318

## Summary
Extract the main logic for agentList component in a separate hook.


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@criamico @kibanamachine @CoenWarmer
[Fleet] Extract hook for agentList table logic (elastic#175528)
ca8652b 
Closes elastic#131153
Follow up of elastic#175318

## Summary
Extract the main logic for agentList component in a separate hook.


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@criamico @kibanamachine @CoenWarmer
[Fleet] Extract hook for agentList table logic (elastic#175528)
62660b1 
Closes elastic#131153
Follow up of elastic#175318

## Summary
Extract the main logic for agentList component in a separate hook.


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@criamico @kibanamachine @fkanout
[Fleet] Extract hook for agentList table logic (elastic#175528)
49ef7a1 
Closes elastic#131153
Follow up of elastic#175318

## Summary
Extract the main logic for agentList component in a separate hook.


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Extract hook for agentList table logic criamico/kibana
3 participants
@jen-huang @elasticmachine @criamico