[Synthetics] Rely on refresh context to update status panel #143308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
changed the title
justinkambic
force-pushed
the
synthetics_use-refresh-context-for-overview-status
branch
from
d83c0ee
to
4975273
Compare
dominiqueclarke
approved these changes
Oct 17, 2022
justinkambic
force-pushed
the
synthetics_use-refresh-context-for-overview-status
branch
from
5e986bb
to
f498e77
Compare
justinkambic
force-pushed
the
synthetics_use-refresh-context-for-overview-status
branch
from
f498e77
to
9a8e9af
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
justinkambic
deleted the
synthetics_use-refresh-context-for-overview-status
branch
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 24, 2022
* main: (57 commits) [Files] Filepicker (elastic#143111) [Infrastructure UI] Replace Lens table with EUI table and own api (elastic#142871) [api-docs] Daily api_docs build (elastic#143829) [api-docs] Daily api_docs build (elastic#143825) [api-docs] Daily api_docs build (elastic#143823) [Security Solution] Restructuring folders of Detection Engine + refactoring Rule Management (elastic#142950) [Dev tools] Fix performance issue with autocomplete suggestions (elastic#143428) [Security Solution] Disable ML rule's edit button link under basic license (elastic#143260) [Lens] Use the language-documentation package for formula (elastic#143649) [api-docs] Daily api_docs build (elastic#143811) [Security Solution] Fix missing title on inspect pop-up (elastic#143601) fix incorrect filters being passed to events table causing duplicate entries in our inpsect tool request tab (elastic#143239) [Security Solution][Endpoint] `get-file` response action kibana download file API (elastic#143708) Rely on refresh context to update stats independently of overview cards. (elastic#143308) [RAM] Rule event log - Fix incorrect results when filtering by message and outcome simultaneously (elastic#143119) [ML] Display link to create data view from error cases in data frame analytics results pages (elastic#143596) Update links in README :) (elastic#143675) Add more tests for ml_inference_logic (elastic#143764) skip failing test suite (elastic#143717) [DOCS] Add assignees to case APIs (elastic#143610) ...
e40pud
pushed a commit
to e40pud/kibana
that referenced
this pull request
Oct 24, 2022
|
POST FF Testing looks good, refresh is working fine now !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We previously intended for the overview status panel on the Synthetics Overview page to refresh at the same time as the cards in the monitor list update. The functionality of how the cards fresh is not as simple to access as I anticipated, so we are moving a dedicated dispatch for data back into the component itself, and referencing the refresh context to trigger updates to the count.
Testing this PR
I am going to trigger a cloud deployment for this PR. You should be able to log in and add/edit monitors for multiple locations. Disable them, make some monitors that are down, and ensure the totals expressed in the status panel are aligned with your expectations.